F8-05 — game-mode chrome cleanup + inspector compact rows #66

2026-05-27T11:39:14Z

developer commented

2026-05-27 11:39:14 +00:00

Closes #48.

Drains six F8 polish items (parent #43) in one feature; full breakdown in the commit message. Key UX changes:

Chrome cleanup

AccountMenu (settings/sessions/theme/language/logout) removed from the in-game header; replaced with a single icon-button light/dark theme toggle that flips an in-memory theme.override. The lobby owns the persisted choice; game-shell unmount clears the override so re-entry re-projects.
The wrap-scrolling radio is gone from the map gear popover. The renderer's wrapMode plumbing is intact for a future engine-side topology flag — only the UI surface is dropped.

Inspector compact rows (single idiom: select + ✓/✗ or contextual edit/remove/add)

Planet name is click-to-edit (✓ icon to apply, Escape cancels).
Production: two <select>s (main + target) on one row, gated by an explicit ✓ apply — auto-submit-on-click is gone.
Cargo routes: single dropdown + contextual actions; the section title moved into the placeholder.
Stationed ship groups: race column moved into a dropdown above the table; hidden when only one race is in orbit.

Docs synced: docs/FUNCTIONAL.md §6.7 (+ _ru mirror), ui/docs/design-system.md (theming section).

Test plan

go-unit CI green
ui-test CI green (vitest + Playwright)
integration CI green
Owner smoke test in browser (per the plan's verification checklist).

🤖 Generated with Claude Code

Closes #48. Drains six F8 polish items (parent #43) in one feature; full breakdown in the commit message. Key UX changes: **Chrome cleanup** - AccountMenu (settings/sessions/theme/language/logout) removed from the in-game header; replaced with a single icon-button light/dark theme toggle that flips an in-memory `theme.override`. The lobby owns the persisted choice; game-shell unmount clears the override so re-entry re-projects. - The wrap-scrolling radio is gone from the map gear popover. The renderer's `wrapMode` plumbing is intact for a future engine-side topology flag — only the UI surface is dropped. **Inspector compact rows** (single idiom: select + ✓/✗ or contextual edit/remove/add) - Planet name is click-to-edit (✓ icon to apply, Escape cancels). - Production: two `<select>`s (main + target) on one row, gated by an explicit ✓ apply — auto-submit-on-click is gone. - Cargo routes: single dropdown + contextual actions; the section title moved into the placeholder. - Stationed ship groups: race column moved into a dropdown above the table; hidden when only one race is in orbit. Docs synced: `docs/FUNCTIONAL.md` §6.7 (+ `_ru` mirror), `ui/docs/design-system.md` (theming section). ## Test plan - [ ] go-unit CI green - [ ] ui-test CI green (vitest + Playwright) - [ ] integration CI green - [ ] Owner smoke test in browser (per the plan's verification checklist). 🤖 Generated with [Claude Code](https://claude.com/claude-code)

developer self-assigned this 2026-05-27 11:39:14 +00:00

developer added 1 commit 2026-05-27 11:39:14 +00:00

feat(ui): F8-05 — game-mode chrome cleanup + inspector compact rows (#48 )

Tests · UI / test (push) Waiting to run

Details

Tests · UI / test (pull_request) Waiting to run

Details

4a23c357e5

Drains six F8 polish items (parent #43) in one feature:

а) Chrome cleanup
- п.6 — remove the AccountMenu (settings/sessions/theme/language/logout
  ∼ rudimentary in-game) and replace it with a single icon-button
  light/dark theme toggle. The toggle flips an in-memory `theme.override`;
  game-shell unmount calls `theme.clearOverride()` so the lobby (and
  any re-entry) re-projects the persisted lobby choice.
- п.8 — remove the wrap-scrolling radio from the map gear popover. The
  per-game `wrapMode` store and the renderer's no-wrap path stay in
  place for a future engine-side topology feature; only the UI surface
  is dropped (wrap is a server-side concept, not a per-session UI
  affordance).

б) Inspector compact rows (single idiom: select + ✓ apply / ✗ cancel,
or contextual edit/remove/add)
- п.13 — planet name is now click-to-edit: clicking the name opens an
  inline `<input>` + ✓ confirm icon; Escape cancels; the explicit
  Rename action button and Cancel button are gone.
- п.14 — production becomes one row: primary `<select>` picks
  industry/materials/research/ship, conditional secondary `<select>`
  picks the target (tech / science / ship class) for research and
  ship contexts. Apply is gated until row state differs from the
  planet's current effective production; auto-submit-on-click is
  replaced by the apply-gate.
- п.16 — cargo routes collapse to one row: a single dropdown
  (COL/CAP/MAT/EMP plus a placeholder that absorbs the old section
  title) and contextual action buttons (add / edit + remove) to the
  right. After a successful pick or remove the dropdown stays on the
  type the user just acted on.
- п.32 — stationed ship groups hoist the race column into a dropdown
  above the table. The dropdown seeds with the player's own race when
  local groups are stationed here, otherwise the first race
  alphabetically; rendered only when more than one race is in orbit.
  The race column is dropped in both single- and multi-race modes —
  the dropdown's value already names the active race.

Tests: unit and Playwright e2e updated for every changed test-id and
flow; new coverage added for `theme.override`, the in-game toggle, the
apply-gate behaviour, and the stationed-race dropdown. i18n keys for
the removed menu items, the wrap radios, the cargo title, and the
explicit `rename.cancel` are dropped from both locales; new
`game.shell.theme_toggle.*`, `production.main/target.*`,
`production.apply/cancel`, `cargo.placeholder`, and
`ship_groups.race_filter.aria` keys land.

Docs synced: `docs/FUNCTIONAL.md` §6.7 + `docs/FUNCTIONAL_ru.md`
mirror drop the torus / no-wrap radio mention; `ui/docs/design-system.md`
documents the lobby-owned persisted picker + the in-game ephemeral
override channel.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

developer added 1 commit 2026-05-27 11:42:27 +00:00

docs(ui): F8-05 — sync inspector topic docs with the new compact rows

Tests · UI / test (pull_request) Successful in 11m1s

Details

aee5f39a7e

- order-composer.md describes the production row's apply-gate (two
  selects + ✓/✗) and the click-to-edit entry point for planetRename.
- cargo-routes-ux.md replaces the four-slot grid description with the
  new single-row dropdown + contextual actions and notes the
  "stays on the picked type" UX rule.
- science-designer-ux.md updates the production-picker integration
  description to the dropdown pair and refreshes the e2e walkthrough
  step.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

developer added 1 commit 2026-05-27 13:22:02 +00:00

feat(ui+legacy): F8-05 owner-feedback round 1 — inspector tweaks + parser

Tests · UI / test (push) Has been cancelled

Details

Tests · UI / test (pull_request) Successful in 2m45s

Details

cc4bc3c2b7

Owner-reported polish on top of #48, plus a legacy-parser gap that
prevented verifying stationed ship groups against a real .REP fixture.

UI:
- Production: drop the empty `(production)` placeholder option. Owned
  planets always produce something, so the primary select now opens on
  `industry` by default when `planet.production` is null/unknown,
  keeping the row inside the four real production kinds at all times.
- Production: lock the row to a single line (no flex-wrap) and strip
  border + padding from the ✓/✗ buttons so the apply/cancel icons read
  as glyphs and the row no longer breaks into two visual rows for
  Research / Ship contexts where both selects are present.
- Cargo routes: the placeholder option is now an `<option disabled>`
  styled like a section header (greyed, italic) and reads "manage
  routes" instead of "cargo routes". The wording shifts the intent
  from a section label to an action prompt.

Legacy parser:
- F8-05 (#48 п.32) "Stationed ship groups" couldn't be verified against
  the dg fixture because the legacy `<Race> Groups` blocks (outside
  battles) and the `Unidentified Groups` block were dropped by the
  parser — both are now wired up. Foreign group rows parse the
  `# T D W S C T Q D P M` columns and resolve the destination against
  the parsed planet tables (rows with an invisible destination drop,
  matching the existing local-group convention). The legacy row
  carries no origin / range columns, so foreign groups surface as
  stationed at the destination.
- Smoke tests on every fixture extended with `otherGroups` and
  `unidentifiedGroups` counts. New focused unit test
  `TestParseOtherAndUnidentifiedGroups` covers the column layout, the
  drop-on-unknown-destination rule, and the `X Y`-only unidentified
  rows.
- `tools/local-dev/reports/dg/KNNTS039.json` and
  `tools/local-dev/reports/dg/KNNTS041.json` regenerated so the
  synthetic-loader fixtures carry the new arrays.
- README updated: the two sections move out of "Skipped sections" into
  a "Foreign and unidentified groups" block; package doc-comment
  reflects the broader scope.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

developer added 1 commit 2026-05-27 14:23:24 +00:00

feat(model+ui): F8-05 — race on OtherGroup, real attribution + N×M label

Tests · UI / test (push) Has been cancelled

Details

Tests · Go / test (pull_request) Successful in 2m6s

Details

Tests · Go / test (push) Successful in 2m6s

Details

Tests · Integration / integration (pull_request) Successful in 1m51s

Details

Tests · UI / test (pull_request) Successful in 3m53s

Details

24c68e9846

Issue #48 п.32 ("Stationed ship groups") shipped with a fragile race
fallback: when a foreign group sat on a non-`other`-kind planet the
inspector printed a generic "foreign" label, which collapsed the
race dropdown to a single uninformative bucket. The engine FBS
contract did not carry per-group race either, so live games hit the
same gap. This patch carries race authoritatively from the engine
through every layer down to the inspector.

Wire format & engine
- `pkg/schema/fbs/report.fbs`: add `race:string` to `OtherGroup` and
  `LocalGroup` (additive — old clients ignore).
- `pkg/schema/fbs/report/`: regenerated Go bindings.
- `ui/frontend/src/proto/galaxy/fbs/report/`: regenerated TS bindings.
- `pkg/model/report.OtherGroup.Race`: new field; carried through
  `LocalGroup` via the embedded `OtherGroup`.
- `pkg/transcoder/report.go`: encode + decode `race` on both
  `LocalGroup` and `OtherGroup`.
- `game/internal/controller/report.go.otherGroup`: set `v.Race`
  from `c.g.Race[c.RaceIndex(sg.OwnerID)].Name` so every emitted
  group — own or foreign — carries the resolved race name.

Legacy parser
- `tools/local-dev/legacy-report/parser.go`: capture the
  `<Race> Groups` header into `pendingOtherGroup.race`, fill local
  group `Race` from `p.rep.Race`, propagate both into the
  `report.OtherGroup` rows.
- Tests + smoke counts updated; regenerated `KNNTS{039,041}.json`
  fixtures so the synthetic loader carries the new field.

UI
- `ui/frontend/src/api/`: `ReportShipGroupBase.race` field;
  synthetic loader + FBS decoder populate it.
- `ui/frontend/src/lib/inspectors/planet/ship-groups.svelte`: the
  stationed-groups inspector picks race directly from
  `group.race` (own falls back to `localRace`, both finally to the
  `race.unknown` placeholder). The planet-owner / "foreign"
  heuristic is gone.
- Row label changes from "N ships mass M" to a compact
  `<class>` | `<N ×>` | `<mass>` three-column layout: the count
  cell is right-aligned tabular, the mass cell is right-aligned
  monospace + tabular, matching the inspector / calculator number
  conventions. Stale i18n keys removed
  (`ship_groups.row.count`, `.row.mass`, `.race.foreign`).
- All affected unit tests (8 files) carry the new `race` field.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

owner approved these changes 2026-05-27 14:38:29 +00:00

developer merged commit 147c7d0a6a into development

2026-05-27 14:59:22 +00:00

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: developer/galaxy-game#66