e71e40eef5
CI / changes (pull_request) Successful in 2s
CI / unit (pull_request) Successful in 11s
CI / integration (pull_request) Successful in 19s
CI / ui (pull_request) Successful in 57s
CI / gate (pull_request) Successful in 0s
CI / deploy (pull_request) Successful in 1m39s
Add a second standalone promo bot to the bot container (answers /start with a localized message + a URL button into the main bot's Mini App) and gate write access in a channel's linked discussion chat: grant on join when the Telegram user is registered and neither admin-suspended nor holding a new chat_muted role, and revoke/grant on the matching moderation change for a member currently in the chat. Eligibility (registered AND NOT suspended AND NOT chat_muted; the game suspension dominates) is resolved once in the backend and reached two ways: the bot's join-time unary ResolveChatEligibility over the existing mTLS bot-link, and a backend chat_access_changed event -> gateway -> ChatGate command (idempotent; a temporary-block-expiry sweeper may over-emit). The bot guards the block/unblock path with getChatMember, since bots cannot list members. A web_app button cannot open another bot's Mini App (it signs initData with the sending bot's token), so the promo button is a t.me ?startapp URL reusing the UI's VITE_TELEGRAM_LINK. The bot must be a chat admin with the restrict-members right and chat_member in its allowed updates. No schema change: chat_muted reuses the data-driven account_roles table.
164 lines
5.2 KiB
Go
164 lines
5.2 KiB
Go
package config
|
|
|
|
import (
|
|
"testing"
|
|
|
|
pkgtel "scrabble/pkg/telemetry"
|
|
)
|
|
|
|
// setBotRequired sets every required bot variable so LoadBot reaches the optional
|
|
// parsing and telemetry checks.
|
|
func setBotRequired(t *testing.T) {
|
|
t.Helper()
|
|
t.Setenv("TELEGRAM_BOT_TOKEN", "bot-token")
|
|
t.Setenv("TELEGRAM_MINIAPP_URL", "https://example.org/app")
|
|
t.Setenv("TELEGRAM_GATEWAY_ADDR", "gateway.example.org:9443")
|
|
t.Setenv("TELEGRAM_BOTLINK_SERVER_NAME", "gateway.example.org")
|
|
t.Setenv("TELEGRAM_BOTLINK_TLS_CERT", "/certs/bot.crt")
|
|
t.Setenv("TELEGRAM_BOTLINK_TLS_KEY", "/certs/bot.key")
|
|
t.Setenv("TELEGRAM_BOTLINK_TLS_CA", "/certs/ca.crt")
|
|
}
|
|
|
|
// TestLoadValidator verifies the validator reads the token, defaults its address
|
|
// and names its telemetry service.
|
|
func TestLoadValidator(t *testing.T) {
|
|
t.Setenv("TELEGRAM_BOT_TOKEN", "secret")
|
|
c, err := LoadValidator()
|
|
if err != nil {
|
|
t.Fatalf("LoadValidator: %v", err)
|
|
}
|
|
if c.Token != "secret" {
|
|
t.Errorf("Token = %q, want secret", c.Token)
|
|
}
|
|
if c.GRPCAddr != defaultValidatorGRPCAddr {
|
|
t.Errorf("GRPCAddr = %q, want %q", c.GRPCAddr, defaultValidatorGRPCAddr)
|
|
}
|
|
if c.Telemetry.ServiceName != "scrabble-telegram-validator" {
|
|
t.Errorf("ServiceName = %q, want scrabble-telegram-validator", c.Telemetry.ServiceName)
|
|
}
|
|
}
|
|
|
|
// TestLoadValidatorRequiresToken verifies the validator fails without a token.
|
|
func TestLoadValidatorRequiresToken(t *testing.T) {
|
|
t.Setenv("TELEGRAM_BOT_TOKEN", "")
|
|
if _, err := LoadValidator(); err == nil {
|
|
t.Fatal("LoadValidator: expected an error without a token, got nil")
|
|
}
|
|
}
|
|
|
|
// TestLoadBot verifies the bot parses the token, channel id and owns_updates and
|
|
// names its telemetry service.
|
|
func TestLoadBot(t *testing.T) {
|
|
setBotRequired(t)
|
|
t.Setenv("TELEGRAM_GAME_CHANNEL_ID", "-100111")
|
|
c, err := LoadBot()
|
|
if err != nil {
|
|
t.Fatalf("LoadBot: %v", err)
|
|
}
|
|
if c.Token != "bot-token" || c.GameChannelID != -100111 {
|
|
t.Errorf("config = token %q / channel %d, want bot-token / -100111", c.Token, c.GameChannelID)
|
|
}
|
|
if !c.OwnsUpdates {
|
|
t.Error("OwnsUpdates = false, want true by default")
|
|
}
|
|
if c.SendRatePerSecond != defaultSendRatePerSecond {
|
|
t.Errorf("SendRatePerSecond = %d, want %d", c.SendRatePerSecond, defaultSendRatePerSecond)
|
|
}
|
|
if c.Telemetry.ServiceName != "scrabble-telegram-bot" {
|
|
t.Errorf("ServiceName = %q, want scrabble-telegram-bot", c.Telemetry.ServiceName)
|
|
}
|
|
}
|
|
|
|
// TestLoadBotOwnsUpdatesOptOut verifies TELEGRAM_OWNS_UPDATES=false disables the
|
|
// long-poll ownership.
|
|
func TestLoadBotOwnsUpdatesOptOut(t *testing.T) {
|
|
setBotRequired(t)
|
|
t.Setenv("TELEGRAM_OWNS_UPDATES", "false")
|
|
c, err := LoadBot()
|
|
if err != nil {
|
|
t.Fatalf("LoadBot: %v", err)
|
|
}
|
|
if c.OwnsUpdates {
|
|
t.Error("OwnsUpdates = true, want false")
|
|
}
|
|
}
|
|
|
|
// TestLoadBotRequired verifies LoadBot fails when a required variable is missing.
|
|
func TestLoadBotRequired(t *testing.T) {
|
|
cases := []string{
|
|
"TELEGRAM_BOT_TOKEN",
|
|
"TELEGRAM_MINIAPP_URL",
|
|
"TELEGRAM_GATEWAY_ADDR",
|
|
"TELEGRAM_BOTLINK_SERVER_NAME",
|
|
"TELEGRAM_BOTLINK_TLS_CERT",
|
|
}
|
|
for _, missing := range cases {
|
|
t.Run(missing, func(t *testing.T) {
|
|
setBotRequired(t)
|
|
t.Setenv(missing, "")
|
|
if _, err := LoadBot(); err == nil {
|
|
t.Fatalf("LoadBot: expected an error without %s, got nil", missing)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
// TestLoadBotChatAndPromo verifies the moderated-chat id and the promo-bot
|
|
// configuration parse, the @-prefix is stripped from the username, and a promo token
|
|
// without a username/link is rejected.
|
|
func TestLoadBotChatAndPromo(t *testing.T) {
|
|
t.Run("parsed", func(t *testing.T) {
|
|
setBotRequired(t)
|
|
t.Setenv("TELEGRAM_CHAT_ID", "-100222")
|
|
t.Setenv("TELEGRAM_PROMO_BOT_TOKEN", "promo-token")
|
|
t.Setenv("TELEGRAM_BOT_USERNAME", "@ScrabbleBot")
|
|
t.Setenv("TELEGRAM_BOT_LINK", "https://t.me/ScrabbleBot/app")
|
|
c, err := LoadBot()
|
|
if err != nil {
|
|
t.Fatalf("LoadBot: %v", err)
|
|
}
|
|
if c.ChatID != -100222 {
|
|
t.Errorf("ChatID = %d, want -100222", c.ChatID)
|
|
}
|
|
if c.PromoBotToken != "promo-token" {
|
|
t.Errorf("PromoBotToken = %q", c.PromoBotToken)
|
|
}
|
|
if c.BotUsername != "ScrabbleBot" {
|
|
t.Errorf("BotUsername = %q, want the leading @ stripped", c.BotUsername)
|
|
}
|
|
if c.BotLinkURL != "https://t.me/ScrabbleBot/app" {
|
|
t.Errorf("BotLinkURL = %q", c.BotLinkURL)
|
|
}
|
|
})
|
|
|
|
t.Run("promo token requires username and link", func(t *testing.T) {
|
|
setBotRequired(t)
|
|
t.Setenv("TELEGRAM_PROMO_BOT_TOKEN", "promo-token")
|
|
if _, err := LoadBot(); err == nil {
|
|
t.Fatal("LoadBot: expected an error for a promo token without username/link")
|
|
}
|
|
})
|
|
|
|
t.Run("disabled by default", func(t *testing.T) {
|
|
setBotRequired(t)
|
|
c, err := LoadBot()
|
|
if err != nil {
|
|
t.Fatalf("LoadBot: %v", err)
|
|
}
|
|
if c.PromoBotToken != "" || c.ChatID != 0 {
|
|
t.Errorf("defaults: promo=%q chat=%d, want empty/0", c.PromoBotToken, c.ChatID)
|
|
}
|
|
})
|
|
}
|
|
|
|
// TestLoadRejectsUnsupportedExporter verifies an exporter outside the supported set
|
|
// fails validation (the validator path).
|
|
func TestLoadRejectsUnsupportedExporter(t *testing.T) {
|
|
t.Setenv("TELEGRAM_BOT_TOKEN", "secret")
|
|
t.Setenv("TELEGRAM_OTEL_TRACES_EXPORTER", "jaeger")
|
|
if _, err := LoadValidator(); err == nil {
|
|
t.Fatal("LoadValidator: expected an error for an unsupported exporter, got nil")
|
|
}
|
|
_ = pkgtel.ExporterNone
|
|
}
|