developer/scrabble-game
1
1
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 2 Wiki Activity

fix(offline): delete a finished local game from the device, not the network #201

Merged
developer merged 1 commits from feature/offline-delete-game into development 2026-07-06 15:06:17 +00:00
Conversation 1 Commits 1 Files Changed 4
+25 -4
developer commented 2026-07-06 14:59:55 +00:00
Owner
Copy Link
Copy Source

Offline bug (contour): deleting a finished local game in the lobby toasted "something went wrong" and the game stayed.

The lobby's finished-game delete (hide) always called gateway.hideGame; for a local (offline) game the transport kill switch (#199) refuses it → toast + rollback. Route by id: a local game is removed from the device store + the source cache (LocalSource.delete); an online game still hides on the backend.

Tests: unit (LocalSource.delete removes from the list — 479), check (0), e2e (196, online hide unchanged), gate 112.8/113. Offline delete is contour-verified (the mock e2e can't enter offline).

Offline bug (contour): deleting a finished local game in the lobby toasted "something went wrong" and the game stayed. The lobby's finished-game delete (`hide`) always called `gateway.hideGame`; for a local (offline) game the transport kill switch (#199) refuses it → toast + rollback. Route by id: a local game is removed from the device store + the source cache (`LocalSource.delete`); an online game still hides on the backend. Tests: unit (`LocalSource.delete` removes from the list — 479), check (0), e2e (196, online hide unchanged), gate 112.8/113. Offline delete is contour-verified (the mock e2e can't enter offline).
developer added 1 commit 2026-07-06 14:59:55 +00:00
fix(offline): delete a finished local game from the device, not the network
CI / changes (pull_request) Successful in 2s
Details
CI / unit (pull_request) Has been skipped
Details
CI / integration (pull_request) Has been skipped
Details
CI / ui (pull_request) Successful in 1m10s
Details
CI / conformance (pull_request) Successful in 10s
Details
CI / gate (pull_request) Successful in 0s
Details
CI / deploy (pull_request) Successful in 1m41s
Details
3a72bc29ba 
The lobby's finished-game delete (hide) always called gateway.hideGame; for a
local (offline) game the transport kill switch refused it, so it toasted and the
game stayed. Route by id: a local game is removed from the device store + the
source cache (LocalSource.delete), an online game still hides on the backend.
owner approved these changes 2026-07-06 15:04:51 +00:00
developer merged commit 2a4b0fb25e into development 2026-07-06 15:06:17 +00:00
developer deleted branch feature/offline-delete-game 2026-07-06 15:06:17 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
owner
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
owner (Ilia) developer
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: developer/scrabble-game#201
Delete Branch "feature/offline-delete-game"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?