developer/scrabble-game
1
1
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 2 Wiki Activity

fix(ui): green both lobby scores on a tie, mute a 0:0 board #95

Merged
developer merged 1 commits from feature/lobby-equal-score-color into development 2026-06-20 19:33:07 +00:00
Conversation 1 Commits 1 Files Changed 4
+71 -24
developer commented 2026-06-20 19:28:57 +00:00
Owner
Copy Link
Copy Source

The lobby tinted only the viewer's own number, and a tie counted as "leading" — so an even score showed only the viewer's number green (reading as if the viewer were ahead), and a fresh 0:0 board did the same.

scoreStanding is now per-seat:

  • viewer's seat: green when leading or tied, red when trailing (unchanged);
  • an opponent's seat: green only when it ties the viewer for the lead — so an equal non-zero score paints both numbers green;
  • when the top score is 0 (nobody has moved), every number stays muted, like a finished game.

Tests: pnpm check (0 errors), pnpm test:unit (297 pass, incl. 8 scoreStanding cases — lead/trail/tie/0:0/non-active/unseated/multiplayer), pnpm build ok. Doc: docs/UI_DESIGN.md score-tint paragraph updated.

The lobby tinted only the viewer's own number, and a tie counted as "leading" — so an even score showed only the viewer's number green (reading as if the viewer were ahead), and a fresh 0:0 board did the same. `scoreStanding` is now per-seat: - viewer's seat: green when leading or tied, red when trailing (unchanged); - an opponent's seat: green only when it ties the viewer for the lead — so an **equal non-zero score paints both numbers green**; - when the top score is 0 (nobody has moved), **every number stays muted**, like a finished game. Tests: `pnpm check` (0 errors), `pnpm test:unit` (297 pass, incl. 8 `scoreStanding` cases — lead/trail/tie/0:0/non-active/unseated/multiplayer), `pnpm build` ok. Doc: `docs/UI_DESIGN.md` score-tint paragraph updated.
developer added 1 commit 2026-06-20 19:28:57 +00:00
fix(ui): green both lobby scores on a tie, mute a 0:0 board
CI / changes (pull_request) Successful in 2s
Details
CI / unit (pull_request) Has been skipped
Details
CI / integration (pull_request) Has been skipped
Details
CI / ui (pull_request) Successful in 54s
Details
CI / gate (pull_request) Successful in 0s
Details
CI / deploy (pull_request) Successful in 1m7s
Details
264097bbf6 
The lobby tinted only the viewer's own number, and a tie counted as
"leading" — so an even score showed only the viewer's number green,
reading as if the viewer were ahead. A fresh 0:0 board did the same,
accenting the start of a game where nobody has scored.

scoreStanding is now per-seat: the viewer's seat stays green when
leading or tied and red when trailing; an opponent's seat greens only
when it ties the viewer for the lead, so an equal non-zero score paints
both numbers green. When the top score is 0 (nobody has moved) every
number is left muted, like a finished game.
owner approved these changes 2026-06-20 19:32:48 +00:00
developer merged commit 2a8717c930 into development 2026-06-20 19:33:07 +00:00
developer deleted branch feature/lobby-equal-score-color 2026-06-20 19:33:07 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
owner
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
owner (Ilia) developer
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: developer/scrabble-game#95
Delete Branch "feature/lobby-equal-score-color"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?