android: shrink adaptive icon mark 25% + full-bleed legacy square + Erudit-only default for the profileless client #271

Merged
developer merged 3 commits from feature/native-icons-variant-defaults into development 2026-07-14 20:23:04 +00:00
Owner

Two native-app polish fixes from emulator testing.

1. Icons (#1)

  • Adaptive foreground mark scaled 0.75 about the icon centre (25% smaller, letter-to-star arrangement unchanged): the star that grazed the round mask now sits well inside the 61% safe zone.
  • Legacy square ic_launcher.png now renders the full-bleed master (large mark) instead of the safe-zone composite, so old Android (< API 26 square launchers) no longer shows a shrunk mark. The legacy round icon keeps the safe-zone composite (a round mask would clip the master's corner star).
  • Regenerated the layer set, per-density Android res and the brandbook foreground previews; updated docs/ICON_BRANDBOOK.md + docs/ICONS.md.

2. Variant default (#2)

  • availableVariants fell back to all three variants for a player with no stored preferences. A fresh offline native launch boots with no profile, so New Game exposed the English game before the player opted in — contrary to the backend's Erudit-only new-account default (already documented in docs/FUNCTIONAL.md). Falls back to DEFAULT_VARIANTS (Erudit only) now; all dictionaries stay bundled.

Both surface in a rebuilt debug APK for on-device retest. Verified locally: svelte-check clean, 634 unit tests green, UI build green, icon regen diff scoped (no flat-derived churn).

Two native-app polish fixes from emulator testing. ## 1. Icons (#1) - **Adaptive foreground** mark scaled 0.75 about the icon centre (**25% smaller**, letter-to-star arrangement unchanged): the star that grazed the round mask now sits well inside the 61% safe zone. - **Legacy square** `ic_launcher.png` now renders the **full-bleed master** (large mark) instead of the safe-zone composite, so old Android (< API 26 square launchers) no longer shows a shrunk mark. The **legacy round** icon keeps the safe-zone composite (a round mask would clip the master's corner star). - Regenerated the layer set, per-density Android res and the brandbook foreground previews; updated `docs/ICON_BRANDBOOK.md` + `docs/ICONS.md`. ## 2. Variant default (#2) - `availableVariants` fell back to **all three** variants for a player with no stored preferences. A fresh offline native launch boots with no profile, so New Game exposed the **English** game before the player opted in — contrary to the backend's Erudit-only new-account default (already documented in `docs/FUNCTIONAL.md`). Falls back to `DEFAULT_VARIANTS` (**Erudit only**) now; all dictionaries stay bundled. Both surface in a rebuilt debug APK for on-device retest. Verified locally: svelte-check clean, 634 unit tests green, UI build green, icon regen diff scoped (no flat-derived churn).
developer added 2 commits 2026-07-14 19:57:50 +00:00
availableVariants fell back to all three variants when the player had no
stored preferences. A fresh offline native launch boots with no profile, so
New Game exposed the English game before the player opted in — contrary to the
backend's Erudit-only new-account default (docs/FUNCTIONAL.md). Fall back to
DEFAULT_VARIANTS (Erudit only) instead; all dictionaries stay bundled.
feat(icons): shrink the Android adaptive mark 25%, give old square launchers the full-bleed master
CI / changes (pull_request) Successful in 2s
CI / unit (pull_request) Has been skipped
CI / integration (pull_request) Has been skipped
CI / ui (pull_request) Failing after 2m10s
CI / conformance (pull_request) Successful in 10s
CI / gate (pull_request) Failing after 0s
CI / deploy (pull_request) Has been skipped
4a3e12c85a
The adaptive foreground's asterisk grazed the round mask's safe zone. Scale the
foreground mark 0.75 about the icon centre (25% smaller, the letter-to-star
arrangement unchanged) so it sits well inside the 61% safe zone. Independently,
the legacy square ic_launcher.png now renders the full-bleed master instead of
the safe-zone composite, so old Android (< API 26) shows a large mark rather
than a shrunk one; the legacy round icon keeps the safe-zone composite (a round
mask would clip the master's corner star). Regenerate the layer set, Android
res and the brandbook foreground previews; update ICON_BRANDBOOK.md / ICONS.md.
owner approved these changes 2026-07-14 20:02:27 +00:00
Dismissed
developer added 1 commit 2026-07-14 20:13:43 +00:00
test(ui): update the native offline-first e2e for the Erudit-only guest default
CI / changes (pull_request) Successful in 2s
CI / unit (pull_request) Has been skipped
CI / integration (pull_request) Has been skipped
CI / ui (pull_request) Successful in 1m14s
CI / conformance (pull_request) Successful in 10s
CI / gate (pull_request) Successful in 0s
CI / deploy (pull_request) Successful in 1m57s
e07886ecb1
The offline native guest is now offered only Erudit (the profileless default
from the variants fix), so the specs that picked the English "Scrabble"
variant timed out. Play Erudit instead: the single `.variant` click both
selects it and asserts nothing else is offered; the vs_ai test plays НОЖ from
the pinned Erudit rack (ОЖЬЯНАО), and the bundled ru_erudit dawg drives the
robot reply.
developer dismissed owner's review 2026-07-14 20:13:43 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

owner approved these changes 2026-07-14 20:21:46 +00:00
developer merged commit b5fe61279b into development 2026-07-14 20:23:04 +00:00
developer deleted branch feature/native-icons-variant-defaults 2026-07-14 20:23:04 +00:00
Sign in to join this conversation.
No Reviewers
No Label
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: developer/scrabble-game#271