feat(payments): reverse refunds issued outside the console
CI / changes (pull_request) Successful in 11s
CI / unit (pull_request) Successful in 22s
CI / integration (pull_request) Successful in 29s
CI / ui (pull_request) Successful in 1m27s
CI / conformance (pull_request) Successful in 19s
CI / gate (pull_request) Successful in 0s
CI / deploy (pull_request) Successful in 1m52s
CI / changes (pull_request) Successful in 11s
CI / unit (pull_request) Successful in 22s
CI / integration (pull_request) Successful in 29s
CI / ui (pull_request) Successful in 1m27s
CI / conformance (pull_request) Successful in 19s
CI / gate (pull_request) Successful in 0s
CI / deploy (pull_request) Successful in 1m52s
Two holes on the refund path, both found by asking what happens when a refund does not come from our own `/_gm` button. The merchant cabinet is a second entry point. An operator can refund there, and such a refund never passes through our API — so the money went back while the chips stayed credited, silently. Handle `refund.succeeded`: the refund is re-read from the API (the notification body is no more evidence here than it is for a payment), bound back to its order through the payment id recorded when the payment was minted, and reversed through the same engine. It is idempotent on (provider, refund id), so the event for a refund the console already recorded reverses nothing twice. The reversal engine is full-refund-only by design — it revokes exactly what the pack funded and rejects any other amount — so a partial refund is recorded as nothing at all and logged loudly for an operator. There is no non-arbitrary way to decide how many chips a part-refund costs, and guessing would be worse than asking a human. Second hole: a refund can still be canceled while pending, and the ledger is append-only. Recording on any non-empty refund id therefore risked revoking a customer's chips for money that stayed with us, with no way to take the row back. The console now records only a `succeeded` refund and tells the operator to press again otherwise — the idempotency key returns the same refund rather than paying twice. Tests: unit (GetRefund, the refund notification envelope, a non-final status surfaced to the caller); integration (a cabinet refund is reversed once and a redelivery is a no-op, the event after a console refund changes nothing, a partial refund records nothing, an unconfirmed refund reverses nothing, a pending refund records nothing until it settles and then does). The suite shares one database and the ledger dedupes refunds globally, so the fake provider now mints a refund id per payment — a constant id made one test's refund look like another's duplicate. Decisions D50 (amended) and D52; the notification subscription list in the deploy docs gains refund.succeeded.
This commit is contained in:
@@ -88,3 +88,33 @@ func TestAllowedSenderUnmapsIPv4(t *testing.T) {
|
||||
t.Error("an IPv4-mapped foreign sender was allowed")
|
||||
}
|
||||
}
|
||||
|
||||
func TestParseRefundNotification(t *testing.T) {
|
||||
n, err := ParseNotification([]byte(`{"type":"notification","event":"refund.succeeded",
|
||||
"object":{"id":"refund-1","status":"succeeded","payment_id":"pay-1",
|
||||
"amount":{"value":"149.00","currency":"RUB"}}}`))
|
||||
if err != nil {
|
||||
t.Fatalf("parse notification: %v", err)
|
||||
}
|
||||
if n.Event != EventRefundSucceeded {
|
||||
t.Errorf("event = %q, want %q", n.Event, EventRefundSucceeded)
|
||||
}
|
||||
r, err := n.Refund()
|
||||
if err != nil {
|
||||
t.Fatalf("decode notification refund: %v", err)
|
||||
}
|
||||
// The refund names the payment, not our order — that is how it is resolved back to one.
|
||||
if r.ID != "refund-1" || r.PaymentID != "pay-1" {
|
||||
t.Errorf("refund = %+v, want refund-1 for pay-1", r)
|
||||
}
|
||||
}
|
||||
|
||||
func TestNotificationRefundNeedsAnID(t *testing.T) {
|
||||
n, err := ParseNotification([]byte(`{"type":"notification","event":"refund.succeeded","object":{"status":"succeeded"}}`))
|
||||
if err != nil {
|
||||
t.Fatalf("parse notification: %v", err)
|
||||
}
|
||||
if _, err := n.Refund(); err == nil {
|
||||
t.Error("a refund object with no id was accepted")
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user