galaxy-game/lobby/internal/service/startgame/service_test.go

package startgame_test

import (
	"context"
	"errors"
	"io"
	"log/slog"
	"testing"
	"time"

	"galaxy/lobby/internal/adapters/gamestub"
	"galaxy/lobby/internal/adapters/runtimemanagerstub"
	"galaxy/lobby/internal/domain/common"
	"galaxy/lobby/internal/domain/game"
	"galaxy/lobby/internal/ports"
	"galaxy/lobby/internal/service/shared"
	"galaxy/lobby/internal/service/startgame"

	"github.com/stretchr/testify/assert"
	"github.com/stretchr/testify/require"
)

func silentLogger() *slog.Logger {
	return slog.New(slog.NewTextHandler(io.Discard, nil))
}

func fixedClock(at time.Time) func() time.Time {
	return func() time.Time { return at }
}

func newReadyGame(t *testing.T, gameType game.GameType, ownerID string) (game.Game, time.Time) {
	t.Helper()
	now := time.Date(2026, 4, 25, 12, 0, 0, 0, time.UTC)
	record, err := game.New(game.NewGameInput{
		GameID:              common.GameID("game-1"),
		GameName:            "test game",
		GameType:            gameType,
		OwnerUserID:         ownerID,
		MinPlayers:          4,
		MaxPlayers:          8,
		StartGapHours:       12,
		StartGapPlayers:     2,
		EnrollmentEndsAt:    now.Add(24 * time.Hour),
		TurnSchedule:        "0 18 * * *",
		TargetEngineVersion: "v1.0.0",
		Now:                 now,
	})
	require.NoError(t, err)
	record.Status = game.StatusReadyToStart
	return record, now
}

type fixture struct {
	games   *gamestub.Store
	runtime *runtimemanagerstub.Publisher
	service *startgame.Service
	now     time.Time
}

func newFixture(t *testing.T, record game.Game, now time.Time) *fixture {
	t.Helper()
	games := gamestub.NewStore()
	require.NoError(t, games.Save(context.Background(), record))
	runtime := runtimemanagerstub.NewPublisher()
	service, err := startgame.NewService(startgame.Dependencies{
		Games:          games,
		RuntimeManager: runtime,
		Clock:          fixedClock(now.Add(time.Hour)),
		Logger:         silentLogger(),
	})
	require.NoError(t, err)
	return &fixture{games: games, runtime: runtime, service: service, now: now}
}

func TestNewServiceRejectsMissingDeps(t *testing.T) {
	_, err := startgame.NewService(startgame.Dependencies{
		RuntimeManager: runtimemanagerstub.NewPublisher(),
	})
	require.Error(t, err)

	_, err = startgame.NewService(startgame.Dependencies{
		Games: gamestub.NewStore(),
	})
	require.Error(t, err)
}

func TestStartGamePublicAdminHappyPath(t *testing.T) {
	record, now := newReadyGame(t, game.GameTypePublic, "")
	f := newFixture(t, record, now)

	updated, err := f.service.Handle(context.Background(), startgame.Input{
		Actor:  shared.NewAdminActor(),
		GameID: record.GameID,
	})
	require.NoError(t, err)
	assert.Equal(t, game.StatusStarting, updated.Status)
	assert.Equal(t, []string{record.GameID.String()}, f.runtime.StartJobs())
	assert.Empty(t, f.runtime.StopJobs())
}

func TestStartGamePrivateOwnerHappyPath(t *testing.T) {
	record, now := newReadyGame(t, game.GameTypePrivate, "user-owner")
	f := newFixture(t, record, now)

	updated, err := f.service.Handle(context.Background(), startgame.Input{
		Actor:  shared.NewUserActor("user-owner"),
		GameID: record.GameID,
	})
	require.NoError(t, err)
	assert.Equal(t, game.StatusStarting, updated.Status)
	assert.Equal(t, []string{record.GameID.String()}, f.runtime.StartJobs())
}

func TestStartGameRejectsNonOwnerUser(t *testing.T) {
	record, now := newReadyGame(t, game.GameTypePrivate, "user-owner")
	f := newFixture(t, record, now)

	_, err := f.service.Handle(context.Background(), startgame.Input{
		Actor:  shared.NewUserActor("user-other"),
		GameID: record.GameID,
	})
	require.ErrorIs(t, err, shared.ErrForbidden)
	assert.Empty(t, f.runtime.StartJobs(), "no start job published on forbidden")

	stored, err := f.games.Get(context.Background(), record.GameID)
	require.NoError(t, err)
	assert.Equal(t, game.StatusReadyToStart, stored.Status, "status must remain ready_to_start")
}

func TestStartGameRejectsPublicUserActor(t *testing.T) {
	record, now := newReadyGame(t, game.GameTypePublic, "")
	f := newFixture(t, record, now)

	_, err := f.service.Handle(context.Background(), startgame.Input{
		Actor:  shared.NewUserActor("user-1"),
		GameID: record.GameID,
	})
	require.ErrorIs(t, err, shared.ErrForbidden)
}

func TestStartGameRejectsWrongStatus(t *testing.T) {
	record, now := newReadyGame(t, game.GameTypePublic, "")
	record.Status = game.StatusEnrollmentOpen
	f := newFixture(t, record, now)

	_, err := f.service.Handle(context.Background(), startgame.Input{
		Actor:  shared.NewAdminActor(),
		GameID: record.GameID,
	})
	require.ErrorIs(t, err, game.ErrConflict)
	assert.Empty(t, f.runtime.StartJobs())
}

func TestStartGameRejectsCASLossOnRecentTransition(t *testing.T) {
	record, now := newReadyGame(t, game.GameTypePublic, "")
	f := newFixture(t, record, now)

	// Concurrent start: simulate someone moved status to starting.
	require.NoError(t, f.games.UpdateStatus(context.Background(), ports.UpdateStatusInput{
		GameID:       record.GameID,
		ExpectedFrom: game.StatusReadyToStart,
		To:           game.StatusStarting,
		Trigger:      game.TriggerCommand,
		At:           now.Add(time.Minute),
	}))

	_, err := f.service.Handle(context.Background(), startgame.Input{
		Actor:  shared.NewAdminActor(),
		GameID: record.GameID,
	})
	require.ErrorIs(t, err, game.ErrConflict)
	assert.Empty(t, f.runtime.StartJobs())
}

func TestStartGamePublishFailureSurfacesUnavailable(t *testing.T) {
	record, now := newReadyGame(t, game.GameTypePublic, "")
	f := newFixture(t, record, now)
	f.runtime.SetStartError(errors.New("redis down"))

	_, err := f.service.Handle(context.Background(), startgame.Input{
		Actor:  shared.NewAdminActor(),
		GameID: record.GameID,
	})
	require.Error(t, err)
	assert.ErrorIs(t, err, shared.ErrServiceUnavailable)

	stored, err := f.games.Get(context.Background(), record.GameID)
	require.NoError(t, err)
	assert.Equal(t, game.StatusStarting, stored.Status,
		"status remains starting; runtime worker resolves orphan via job result")
}

func TestStartGameRejectsMissingRecord(t *testing.T) {
	games := gamestub.NewStore()
	runtime := runtimemanagerstub.NewPublisher()
	service, err := startgame.NewService(startgame.Dependencies{
		Games:          games,
		RuntimeManager: runtime,
		Clock:          fixedClock(time.Now().UTC()),
		Logger:         silentLogger(),
	})
	require.NoError(t, err)

	_, err = service.Handle(context.Background(), startgame.Input{
		Actor:  shared.NewAdminActor(),
		GameID: common.GameID("game-missing"),
	})
	require.ErrorIs(t, err, game.ErrNotFound)
}