Ilia Denisov
723885e74e
Tests · UI / test (push) Has been cancelled
Tests · Go / test (push) Successful in 2m3s
Tests · Go / test (pull_request) Successful in 2m5s
Tests · Integration / integration (pull_request) Successful in 1m44s
Tests · UI / test (pull_request) Failing after 4m28s
Three issues surfaced once the per-command rejection from the previous commit actually reached the UI: 1. Sync banner falsely red. `OrderDraftStore.runSync` flipped `syncStatus = "error"` whenever any command was rejected and advertised a Retry button. A per-command rejection is a player-correctable state — the round trip succeeded, the engine just refused that command — so the retry can't help. Keep `syncStatus = "synced"` on `success`; the red row highlight is the visible cue. 2. Rejection reason missing. Add `cmd_error_message: string` to `CommandItem` in `pkg/schema/fbs/order.fbs` (appended last to preserve existing slot offsets) and regenerate the Go + TS stubs for that one type. Plumb the message through `CommandMeta`, `Controller.applyCommand`'s `m.Result(code, message)` call, the Go transcoder, the UI decoders in `submit.ts` / `order-load.ts`, and the `OrderDraftStore.errorMessages` map. `order-tab.svelte` renders it as an italic danger-coloured line under rejected commands, with new CSS for `.error-reason`. 3. Verdict lost on navigation. `order-load.ts.decodeCommand` never read `cmdApplied`/`cmdErrorCode`, so `hydrateFromServer` fell back to a blanket "applied" status — a previously-rejected command came back green after a lobby → game round trip. Extend the fetch decoder to populate `statuses`/`errorCodes`/ `errorMessages` maps and have `hydrateFromServer` use them. Engine-side persistence already records the verdict on disk — verified against the live `0000/order/<id>.json`. `flatbuffers@25` elides default-int8/int64 fields on write; the Go transcoder force-slots `cmd_applied=false` / `cmd_error_code=0` already, the new test fixtures flip `builder.forceDefaults(true)` to mirror that behaviour so the round trip survives. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
133 lines
3.4 KiB
Go
133 lines
3.4 KiB
Go
// Code generated by the FlatBuffers compiler. DO NOT EDIT.
|
|
|
|
package order
|
|
|
|
import (
|
|
flatbuffers "github.com/google/flatbuffers/go"
|
|
)
|
|
|
|
type CommandItem struct {
|
|
_tab flatbuffers.Table
|
|
}
|
|
|
|
func GetRootAsCommandItem(buf []byte, offset flatbuffers.UOffsetT) *CommandItem {
|
|
n := flatbuffers.GetUOffsetT(buf[offset:])
|
|
x := &CommandItem{}
|
|
x.Init(buf, n+offset)
|
|
return x
|
|
}
|
|
|
|
func FinishCommandItemBuffer(builder *flatbuffers.Builder, offset flatbuffers.UOffsetT) {
|
|
builder.Finish(offset)
|
|
}
|
|
|
|
func GetSizePrefixedRootAsCommandItem(buf []byte, offset flatbuffers.UOffsetT) *CommandItem {
|
|
n := flatbuffers.GetUOffsetT(buf[offset+flatbuffers.SizeUint32:])
|
|
x := &CommandItem{}
|
|
x.Init(buf, n+offset+flatbuffers.SizeUint32)
|
|
return x
|
|
}
|
|
|
|
func FinishSizePrefixedCommandItemBuffer(builder *flatbuffers.Builder, offset flatbuffers.UOffsetT) {
|
|
builder.FinishSizePrefixed(offset)
|
|
}
|
|
|
|
func (rcv *CommandItem) Init(buf []byte, i flatbuffers.UOffsetT) {
|
|
rcv._tab.Bytes = buf
|
|
rcv._tab.Pos = i
|
|
}
|
|
|
|
func (rcv *CommandItem) Table() flatbuffers.Table {
|
|
return rcv._tab
|
|
}
|
|
|
|
func (rcv *CommandItem) CmdId() []byte {
|
|
o := flatbuffers.UOffsetT(rcv._tab.Offset(4))
|
|
if o != 0 {
|
|
return rcv._tab.ByteVector(o + rcv._tab.Pos)
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func (rcv *CommandItem) CmdApplied() *bool {
|
|
o := flatbuffers.UOffsetT(rcv._tab.Offset(6))
|
|
if o != 0 {
|
|
v := rcv._tab.GetBool(o + rcv._tab.Pos)
|
|
return &v
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func (rcv *CommandItem) MutateCmdApplied(n bool) bool {
|
|
return rcv._tab.MutateBoolSlot(6, n)
|
|
}
|
|
|
|
func (rcv *CommandItem) CmdErrorCode() *int64 {
|
|
o := flatbuffers.UOffsetT(rcv._tab.Offset(8))
|
|
if o != 0 {
|
|
v := rcv._tab.GetInt64(o + rcv._tab.Pos)
|
|
return &v
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func (rcv *CommandItem) MutateCmdErrorCode(n int64) bool {
|
|
return rcv._tab.MutateInt64Slot(8, n)
|
|
}
|
|
|
|
func (rcv *CommandItem) PayloadType() CommandPayload {
|
|
o := flatbuffers.UOffsetT(rcv._tab.Offset(10))
|
|
if o != 0 {
|
|
return CommandPayload(rcv._tab.GetByte(o + rcv._tab.Pos))
|
|
}
|
|
return 0
|
|
}
|
|
|
|
func (rcv *CommandItem) MutatePayloadType(n CommandPayload) bool {
|
|
return rcv._tab.MutateByteSlot(10, byte(n))
|
|
}
|
|
|
|
func (rcv *CommandItem) Payload(obj *flatbuffers.Table) bool {
|
|
o := flatbuffers.UOffsetT(rcv._tab.Offset(12))
|
|
if o != 0 {
|
|
rcv._tab.Union(obj, o)
|
|
return true
|
|
}
|
|
return false
|
|
}
|
|
|
|
func (rcv *CommandItem) CmdErrorMessage() []byte {
|
|
o := flatbuffers.UOffsetT(rcv._tab.Offset(14))
|
|
if o != 0 {
|
|
return rcv._tab.ByteVector(o + rcv._tab.Pos)
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func CommandItemStart(builder *flatbuffers.Builder) {
|
|
builder.StartObject(6)
|
|
}
|
|
func CommandItemAddCmdId(builder *flatbuffers.Builder, cmdId flatbuffers.UOffsetT) {
|
|
builder.PrependUOffsetTSlot(0, flatbuffers.UOffsetT(cmdId), 0)
|
|
}
|
|
func CommandItemAddCmdApplied(builder *flatbuffers.Builder, cmdApplied bool) {
|
|
builder.PrependBool(cmdApplied)
|
|
builder.Slot(1)
|
|
}
|
|
func CommandItemAddCmdErrorCode(builder *flatbuffers.Builder, cmdErrorCode int64) {
|
|
builder.PrependInt64(cmdErrorCode)
|
|
builder.Slot(2)
|
|
}
|
|
func CommandItemAddPayloadType(builder *flatbuffers.Builder, payloadType CommandPayload) {
|
|
builder.PrependByteSlot(3, byte(payloadType), 0)
|
|
}
|
|
func CommandItemAddPayload(builder *flatbuffers.Builder, payload flatbuffers.UOffsetT) {
|
|
builder.PrependUOffsetTSlot(4, flatbuffers.UOffsetT(payload), 0)
|
|
}
|
|
func CommandItemAddCmdErrorMessage(builder *flatbuffers.Builder, cmdErrorMessage flatbuffers.UOffsetT) {
|
|
builder.PrependUOffsetTSlot(5, flatbuffers.UOffsetT(cmdErrorMessage), 0)
|
|
}
|
|
func CommandItemEnd(builder *flatbuffers.Builder) flatbuffers.UOffsetT {
|
|
return builder.EndObject()
|
|
}
|