chore(cleanup): purge /command residuals — fakeEngine, canon golden, openapi #75

2026-05-30T13:16:18Z

developer commented

2026-05-30 13:16:18 +00:00

Three small follow-ups agreed after the /command removal (#73):

dummyExecutor → fakeEngine in the router tests (+ newExecutor/setupRouterExecutor → newFakeEngine/setupRouterEngine). It implements handler.Engine now; executor was a dead-concept leftover. Test-only.
canon signing golden regenerated onto user.games.order (request_user_games_command.json → request_user_games_order.json, fresh canonical bytes + Ed25519 signature) — purges the last user.games.command references from the Go/TS tests and docs. The Go fixture test + the WASM-parity vitest validate it.
openapi CommandRequest.cmd drops minItems: 1. It is now order-only, and PUT /api/v1/order accepts an empty batch (clearing the stored order, equivalent to removing every command); the contract test freezes the empty-allowed shape.

No production behaviour change.

Three small follow-ups agreed after the `/command` removal (#73): - **`dummyExecutor` → `fakeEngine`** in the router tests (+ `newExecutor`/`setupRouterExecutor` → `newFakeEngine`/`setupRouterEngine`). It implements `handler.Engine` now; `executor` was a dead-concept leftover. Test-only. - **canon signing golden regenerated onto `user.games.order`** (`request_user_games_command.json` → `request_user_games_order.json`, fresh canonical bytes + Ed25519 signature) — purges the last `user.games.command` references from the Go/TS tests and docs. The Go fixture test + the WASM-parity vitest validate it. - **openapi `CommandRequest.cmd` drops `minItems: 1`.** It is now order-only, and `PUT /api/v1/order` accepts an empty batch (clearing the stored order, equivalent to removing every command); the contract test freezes the empty-allowed shape. No production behaviour change.

developer added 1 commit 2026-05-30 13:16:18 +00:00

chore(cleanup): purge /command residuals — fakeEngine, canon golden, openapi

Tests · UI / test (pull_request) Has been cancelled

Details

Tests · Integration / integration (pull_request) Successful in 1m46s

Details

Tests · Go / test (pull_request) Successful in 2m4s

Details

Tests · Go / test (push) Successful in 2m28s

Details

Tests · UI / test (push) Successful in 3m22s

Details

bde9d535dc

Follow-up tidy after the cross-service /command removal (#73):

- Rename the router test double dummyExecutor -> fakeEngine (and the
  newExecutor / setupRouterExecutor helpers -> newFakeEngine /
  setupRouterEngine): it implements handler.Engine now, "executor" was a
  leftover of the removed adapter. Test-only.

- Regenerate the ui/core canon signing golden onto user.games.order
  (request_user_games_command.json -> request_user_games_order.json, fresh
  canonical bytes + Ed25519 signature) and drop the last
  user.games.command references from the Go/TS tests and docs.

- Align game openapi: CommandRequest.cmd no longer carries minItems: 1. It
  is now used only by PUT /api/v1/order, which accepts an empty batch
  (clearing the player's stored order, equivalent to removing every
  command); the contract test freezes the empty-allowed shape.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

owner approved these changes 2026-05-30 17:54:06 +00:00

developer merged commit 97b5535c02 into development

2026-05-30 17:54:47 +00:00

developer deleted branch feature/post-command-cleanup

2026-05-30 17:54:47 +00:00

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: developer/galaxy-game#75