Ilia Denisov
f9faebfa91
CI / changes (pull_request) Successful in 2s
CI / unit (pull_request) Successful in 10s
CI / integration (pull_request) Successful in 13s
CI / ui (pull_request) Successful in 51s
CI / gate (pull_request) Successful in 0s
CI / deploy (pull_request) Successful in 2m20s
The in-game hint badge re-fetched on entry and, for a game where it was the player's turn, showed a too-high count that "reset" (e.g. back to 11) — the wallet hint spent in another game was not reflected. Root cause: the server sends one hints_remaining = per-game allowance + global wallet, and the client cached that combined number per game. The wallet is global, so spending a wallet hint in one game left every other game's cached count stale (a my-turn game holds the stalest value: the opponent-moved delta preserves the old number, whereas a game you just moved in re-cached a fresh one). The backend allowance-then-wallet spend order was already correct. Fix: split the two. StateView/HintResult gain a trailing wallet_balance field (the global wallet alone); the client derives the per-game allowance as hints_remaining - wallet_balance (stable, cacheable) and reads the wallet live from the profile, refreshing it from every state/hint response. The badge is allowance + live wallet, so a wallet hint anywhere updates every game at once. - wire: scrabble.fbs StateView/HintResult + pkg/wire.BuildStateView (the single encoder for both the gateway transcode and the backend's event StateView), gateway encode + resp structs, regen. - backend: game StateView/HintResult + service (GameState/Hint) + eventwire + notify PlayerState/encode + server DTOs. - ui: lib/hints.ts (pure hintsLeft), Game.svelte (badge + syncWallet on load/hint, carry wallet_balance through applyMoveResult), codec/model, mock. - docs: ARCHITECTURE §Hint. Tests: hints.ts unit (incl. the staleness case), TestHintPolicy extended (wallet_balance + allowance-first), gateway state/hint round-trips.
33 lines
1.3 KiB
TypeScript
33 lines
1.3 KiB
TypeScript
import { describe, expect, it } from 'vitest';
|
|
import { hintsLeft } from './hints';
|
|
|
|
// view carries only the two fields hintsLeft reads.
|
|
const view = (hintsRemaining: number, walletBalance: number) => ({ hintsRemaining, walletBalance });
|
|
|
|
describe('hintsLeft', () => {
|
|
it('is zero without a view', () => {
|
|
expect(hintsLeft(null, 5)).toBe(0);
|
|
});
|
|
|
|
it('adds the per-game allowance to the live wallet (fresh view)', () => {
|
|
// hints_remaining 4 = allowance 1 + wallet 3; live wallet matches the snapshot → 1 + 3.
|
|
expect(hintsLeft(view(4, 3), 3)).toBe(4);
|
|
});
|
|
|
|
it('reflects the LIVE wallet, not the per-game snapshot (the staleness fix)', () => {
|
|
// The view was fetched when the wallet was 3 (allowance 1), but a wallet hint was since spent
|
|
// in another game, so the live wallet is 2: the count must drop to 1 + 2 = 3, not stay at 4.
|
|
expect(hintsLeft(view(4, 3), 2)).toBe(3);
|
|
});
|
|
|
|
it('shows just the wallet when the per-game allowance is used up', () => {
|
|
// allowance 0 (hints_remaining 3 == snapshot wallet 3); live wallet 3 → 0 + 3.
|
|
expect(hintsLeft(view(3, 3), 3)).toBe(3);
|
|
});
|
|
|
|
it('clamps a non-negative allowance and wallet', () => {
|
|
expect(hintsLeft(view(2, 3), 0)).toBe(0);
|
|
expect(hintsLeft(view(1, 0), -5)).toBe(1);
|
|
});
|
|
});
|