Ilia Denisov
ab58062565
- accounts.flagged_high_rate_at baked into the R1 baseline (no prod data; the contour schema is wiped after merge); jet regenerated — the regen also picks up the previously missing game_drafts/game_hidden models. - account.Store: FlagHighRate (set-once), ClearHighRateFlag, the flag in GetByID/ListUsers and a ListFlaggedHighRate review queue. - New internal/ratewatch: ingests the gateway rejection reports, keeps a bounded in-memory episode window for the console and applies the conservative auto-flag (1000 rejected / 10 min, BACKEND_HIGHRATE_FLAG_*). - POST /api/v1/internal/ratelimit/report (network-trusted, like sessions/resolve). - Admin console: Throttled page (episodes + flagged accounts), a high-rate badge in the user list, the marker + operator clear action on the user card. - Tests: ratewatch unit suite, report-route handler test, renderer cases, integration coverage for the store round-trip and the console flow.
119 lines
4.2 KiB
Go
119 lines
4.2 KiB
Go
package server
|
|
|
|
import (
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/google/uuid"
|
|
|
|
"scrabble/backend/internal/account"
|
|
"scrabble/backend/internal/game"
|
|
"scrabble/backend/internal/ratewatch"
|
|
"scrabble/backend/internal/session"
|
|
)
|
|
|
|
// newRoutingServer builds a Server with non-nil (zero-value) services so the
|
|
// routes register. The tests below exercise only the request-validation and
|
|
// routing layers, which return before any service method is called; full
|
|
// endpoint behaviour against real services is covered by the integration suite.
|
|
func newRoutingServer() *Server {
|
|
return New(":0", Deps{
|
|
Sessions: &session.Service{},
|
|
Accounts: &account.Store{},
|
|
Games: &game.Service{},
|
|
})
|
|
}
|
|
|
|
func do(t *testing.T, s *Server, method, path, body string, headers map[string]string) *httptest.ResponseRecorder {
|
|
t.Helper()
|
|
var rdr *strings.Reader
|
|
if body != "" {
|
|
rdr = strings.NewReader(body)
|
|
} else {
|
|
rdr = strings.NewReader("")
|
|
}
|
|
req := httptest.NewRequest(method, path, rdr)
|
|
req.Header.Set("Content-Type", "application/json")
|
|
for k, v := range headers {
|
|
req.Header.Set(k, v)
|
|
}
|
|
rec := httptest.NewRecorder()
|
|
s.Handler().ServeHTTP(rec, req)
|
|
return rec
|
|
}
|
|
|
|
func TestProfileRequiresUserID(t *testing.T) {
|
|
rec := do(t, newRoutingServer(), http.MethodGet, "/api/v1/user/profile", "", nil)
|
|
if rec.Code != http.StatusUnauthorized {
|
|
t.Fatalf("profile without X-User-ID = %d, want 401", rec.Code)
|
|
}
|
|
}
|
|
|
|
func TestResolveSessionRejectsEmptyToken(t *testing.T) {
|
|
rec := do(t, newRoutingServer(), http.MethodPost, "/api/v1/internal/sessions/resolve", `{}`, nil)
|
|
if rec.Code != http.StatusBadRequest {
|
|
t.Fatalf("resolve with empty token = %d, want 400", rec.Code)
|
|
}
|
|
}
|
|
|
|
// TestRateLimitReportEndpoint covers the internal R3 report route: a malformed
|
|
// body is a 400, a valid report lands in the rate watch with 204.
|
|
func TestRateLimitReportEndpoint(t *testing.T) {
|
|
watch := ratewatch.New(ratewatch.DefaultConfig(), nil, nil)
|
|
s := New(":0", Deps{RateWatch: watch})
|
|
if rec := do(t, s, http.MethodPost, "/api/v1/internal/ratelimit/report", `{bad`, nil); rec.Code != http.StatusBadRequest {
|
|
t.Fatalf("malformed report = %d, want 400", rec.Code)
|
|
}
|
|
body := `{"window_seconds":30,"entries":[{"class":"user","key":"` + uuid.NewString() + `","rejected":7}]}`
|
|
if rec := do(t, s, http.MethodPost, "/api/v1/internal/ratelimit/report", body, nil); rec.Code != http.StatusNoContent {
|
|
t.Fatalf("report = %d, want 204", rec.Code)
|
|
}
|
|
if eps := watch.Recent(); len(eps) != 1 || eps[0].Rejected != 7 {
|
|
t.Fatalf("watch episodes = %+v, want one entry with rejected=7", eps)
|
|
}
|
|
}
|
|
|
|
func TestSubmitPlayRejectsBadDirection(t *testing.T) {
|
|
headers := map[string]string{"X-User-ID": uuid.New().String()}
|
|
path := "/api/v1/user/games/" + uuid.New().String() + "/play"
|
|
rec := do(t, newRoutingServer(), http.MethodPost, path, `{"dir":"X","tiles":[]}`, headers)
|
|
if rec.Code != http.StatusBadRequest {
|
|
t.Fatalf("submit play bad dir = %d, want 400", rec.Code)
|
|
}
|
|
}
|
|
|
|
func TestSubmitPlayRejectsBadGameID(t *testing.T) {
|
|
headers := map[string]string{"X-User-ID": uuid.New().String()}
|
|
rec := do(t, newRoutingServer(), http.MethodPost, "/api/v1/user/games/not-a-uuid/play", `{"dir":"H"}`, headers)
|
|
if rec.Code != http.StatusBadRequest {
|
|
t.Fatalf("submit play bad game id = %d, want 400", rec.Code)
|
|
}
|
|
}
|
|
|
|
func TestGetDraftRequiresUserID(t *testing.T) {
|
|
path := "/api/v1/user/games/" + uuid.New().String() + "/draft"
|
|
rec := do(t, newRoutingServer(), http.MethodGet, path, "", nil)
|
|
if rec.Code != http.StatusUnauthorized {
|
|
t.Fatalf("get draft without X-User-ID = %d, want 401", rec.Code)
|
|
}
|
|
}
|
|
|
|
func TestSaveDraftRejectsBadGameID(t *testing.T) {
|
|
headers := map[string]string{"X-User-ID": uuid.New().String()}
|
|
rec := do(t, newRoutingServer(), http.MethodPut, "/api/v1/user/games/not-a-uuid/draft", `{"rack_order":"","board_tiles":[]}`, headers)
|
|
if rec.Code != http.StatusBadRequest {
|
|
t.Fatalf("save draft bad game id = %d, want 400", rec.Code)
|
|
}
|
|
}
|
|
|
|
func TestSaveDraftRejectsBadBody(t *testing.T) {
|
|
headers := map[string]string{"X-User-ID": uuid.New().String()}
|
|
path := "/api/v1/user/games/" + uuid.New().String() + "/draft"
|
|
rec := do(t, newRoutingServer(), http.MethodPut, path, `not json`, headers)
|
|
if rec.Code != http.StatusBadRequest {
|
|
t.Fatalf("save draft bad body = %d, want 400", rec.Code)
|
|
}
|
|
}
|