e2771826fd
CI / changes (pull_request) Successful in 2s
CI / unit (pull_request) Successful in 10s
CI / integration (pull_request) Successful in 18s
CI / ui (pull_request) Has been skipped
CI / gate (pull_request) Successful in 0s
CI / deploy (pull_request) Successful in 1m5s
The loadtest harness never modelled game.evaluate — the debounced per-tile play preview a real client fires several times per turn, the hottest gameplay call. Model it (one evaluate per placed tile + reconsideration re-previews + draft.save, human-paced; --eval / --eval-recon toggle it). That realistic load surfaced the real bottleneck: the gateway's backend HTTP client used the default transport (MaxIdleConnsPerHost=2), so every sync call to the single backend host churned a fresh TCP connection — ~26500 TIME_WAIT sockets at 500 players (near the ephemeral-port ceiling), burning ~1.75 gateway cores while the backend sat near-idle. It was the unfixed root of the residual transport_error the earlier passes chased on the client side. Widen the keep-alive pool (backendMaxIdleConns=512, ~2x the observed 225-conn peak). At 500 players the churn collapses to ~0 and peak gateway CPU drops ~7x (~1.75 -> ~0.26 cores); postgres (~1.65 cores) becomes the busiest service. This overturns the earlier "gateway is the binding constraint, scale it horizontally" sizing — that was sizing around this bug, not a real floor. Consolidate the loadtest trip reports into one loadtest/REPORT.md (drop the R2/R7 split) and bake the finding into README / PRERELEASE / ARCHITECTURE / TESTING.
12 KiB
12 KiB
Scrabble Game — Testing
How the project is tested and the gate every stage must pass. Read before adding tests or touching CI.
Layers
- Go unit tests — table-driven where it helps;
testing+ standard library. Every functional change ships with regression coverage. Run:go test -count=1 ./backend/... ./pkg/... ./gateway/...(the module list grows with the workspace). - Integration — Postgres-backed tests behind the
integrationbuild tag spin a throwawaypostgres:17-alpineviatestcontainers-go. They live inbackend/internal/inttestand run withgo test -tags=integration -count=1 -p=1 ./backend/...(needs Docker), guarded by a separate CI workflow (integration.yaml; Ryuk disabled, serial). Slow. - UI — Vitest (unit) + Playwright (e2e), mirroring the chosen plain-Svelte + Vite toolchain. Vitest covers the FlatBuffers codecs (friend list, invitation, stats), the win-rate derivation and the GCG share/download choice, plus Playwright specs against the mock for the friends screen (code issue/redeem, accept a request), the lobby invitations section, the stats screen, profile editing, and the GCG export's finished-only visibility.
- Engine — correctness of scoring and move generation is owned
by
scrabble-solver's own GCG-backed tests.backend/internal/engineadds, on top of the embedded solver: per-variant smoke tests (load all three committed DAWGs and validate a known word, including Эрудит), bag draw/return determinism and exchange accounting, theGameend-conditions (empty bag with an empty rack, and six scoreless turns) with end-game rack scoring, and dictionary-independent history replay (ReplayBoardreproduces a full greedy game's final board from decoded records alone), and the resignation win/loss rule (the resigner keeps their score yet loses). The engine tests read the DAWGs fromBACKEND_DICT_DIR(or the siblingscrabble-solvercheckout) and fail loudly when it is absent. - Game domain —
backend/internal/gameadds pure unit tests (the GCG writer, the away-window / effective-deadline boundaries, the hint budget, the live-game cache and per-game lock, payload round-trips) plus Postgres-backed integration tests ininttest(full lifecycle to a natural end, journal-replay equivalence, the turn-timeout sweep with away-window grace, resign win/loss and statistics, the hint allowance-then-wallet policy, word-check and complaint capture, and per-game-lock serialisation). It also covers the engine's multi-player drop-out cases (continue after one resign, last-survivor win, the tile-disposition bag effect) and a domain integration test for a 3-player timeout that continues, and the engine'sCandidatesranked/decoded test. - Social & lobby —
backend/internal/socialunit-tests the chat content filter (links/emails/phones plus obfuscated forms) andbackend/internal/lobbyunit-tests the in-memory matchmaker (FIFO pairing, cancel, per-variant pools, plus the robot substitution reaper andPolldelivery) with fake game-creator and robot-provider seams. Postgres-backedinttestcovers the friend request/accept lifecycle with the block/toggle guards, the per-user block (and its severing of friendships), chat post/list with the IP, content and block-visibility rules, the nudge turn/rate-limit rules, the invitation flow (all-accept starts the game, decline cancels, lazy expiry, inviter-only cancel), and the email confirm-code flow (request/confirm, taken email, expiry and attempt-cap) with a fixture mailer. It also covers the befriend-an-opponent gate (a request needs a shared game), the permanent decline and 30-day re-send rule, the one-time friend code (issue/redeem, self/single-use, decline-bypass),ListInvitations, the zero-valueGetStats, and the GCG finished-only gate. - Robot —
backend/internal/robotunit-tests the pure strategy: the ≈ 40% play-to-win split over many seeds, the right-skewed move-delay (bounds, ~10-min median, determinism), the margin selection (win/lose, in-band and out-of-band fallbacks, no-play exchange/pass), the sleep window with drift and the midnight wrap, and mix restart-stability. Postgres-backedinttestdrives a robot through a full auto-match to a natural end (asserting a robot statistics row), the matchmaker substitution end-to-end (enqueue → reap →[human, robot], discoverable viaPoll), and a proactive 12-hour nudge. - Gateway & contracts —
backend/internal/notifyunit-tests the hub fan-out (delivery, overflow drop, unsubscribe) and the FlatBuffers event constructors (payload round-trip).gateway/...unit-tests are hermetic (no real network — anhttptestfake backend and fixtures): the Telegram initData HMAC validator (genuine, tampered, wrong-token, stale), the session cache (hit/miss/fallback, TTL re-resolve, invalidate), the rate limiter (burst, per-key isolation, per-window), the push hub (per-user routing, overflow, unsubscribe), the transcode round-trips (FlatBuffers↔JSON, X-User-ID forwarding, nested GameView, domain-code surfacing), the admin Basic-Auth reverse proxy (401 / forward), and a full ConnectExecutepath end to end (guest auth, unauthenticated rejection, unknown message type). The edge-hardening cases: an oversizedExecutepayload is refused (resource_exhausted, theGATEWAY_MAX_BODY_BYTEScap), a limiter rejection lands ingateway_rate_limited_total{class}and the rejection tracker (drain/aggregate unit tests), the report POST reaches/api/v1/internal/ratelimit/reportwith the agreed JSON shape, the/_gmmount is 429-guarded by the per-IP admin class, and the gateway's/308-redirects to/app/(the landing left the embed). The backend covers the guest lifecycle (a guest plays an auto-match to a natural end yet accrues no statistics) and the email-as-login flow (request/verify, returning user) ininttest. Gateway transcode round-trips cover the social/account operations (friends list, friend code issue/redeem, invitation create, stats, GCG, the profile-update away round-trip) and anotify-event constructor round-trip. - Admin & dictionary ops —
backend/internal/adminconsoleunit-tests the template renderer over every page plus the embedded asset;backend/internal/engineadds the dictionary cases (LoadAvailableloads only the present variants,OpenWithVersionsscans version subdirectories and skips the staging area,DiffWordsdecodes the words added/removed between two versions);backend/internal/dictadminunit-tests the release-archive validation and hardened extraction (path-traversal, symlink, oversize and entry-count rejection, immutable versions);backend/internal/serverunit-tests the console's same-origin CSRF guard; the gateway adds the verbatim/_gmBasic-Auth proxy (401 / forward, path preserved) and the h2c console mount (routed when configured, 404 when not). Postgres-backedinttestdrives the complaint resolution → dictionary-change pipeline (file → resolve with a disposition → pending change → mark applied), the dictionary update flow (upload a release archive over HTTP → preview → install → the new version becomes active and resident, persists across a restart, pins new games while in-progress games keep theirs, and is immutable), the admin list/count read queries, and the /_gm console over HTTP (pages render; a resolve POST needs a same-origin header).ratewatchhas unit tests (window accumulation, the auto-flag threshold + expiry, the bounded episode map), the account-store high-rate flag round-trip (set-once / clear / re-flag) and a console flow ininttest: a gateway report auto-flags the account, the Throttled page shows the episode and the flagged queue, the user card carries the marker and the CSRF-guarded Clear reverses it. - Observability & performance —
pkg/telemetryunit-tests the exporter selection (none/stdout/otlpbuild providers; OTLP constructs with no collector; the nil-runtime fallback). The domain metrics are exercised through a manualsdkmetricreader:backend/internal/gameand…/socialassert the counters and histograms record with the rightvariant/kindattributes, andgateway/internal/connectsrvassertsedge_request_durationbymessage_type/result. Config tests cover the new telemetry env vars (backend/gateway/connector —otlpnow accepted, an unsupported exporter rejected) and the guest-reaper knobs. Postgres-backedinttestdrives the guest reaper end to end (an abandoned guest is reaped; a too-young guest, a seated guest and a durable account are kept). - Load test & resource baseline — a reusable
loadtest/module (scrabble/loadtest) is the pre-release stress harness. It seeds a large account population with pre-created sessions directly in Postgres (token hashes matchingbackend/internal/session), drives virtual players through the edge protocol — real games assembled via invitations, mid-ranked legal moves generated locally by the embeddedscrabble-solver(the edge carries no board, so the client replays history) — plus a fraction of nudge/chat/check-word/draft/profile/stats ops, and a gateway-hammer that verifies the rate limiter. Its own Go unit tests cover the pure pieces (token hashing, board replay vs.board.Parse, rack reconstruction, mid-rank selection, the report); the DAWG-backed move test runs underBACKEND_DICT_DIR(as the engine tests do). It is not part of the per-PR suite's behavioural assertions: it runs ad hoc as a one-shot container against the contour, producing a trip report (bugs- a per-container resource profile) read off the otelcol
docker_stats+ postgres_exporter Grafana dashboard on the contour. The findings — including thegame.evaluatehot-path model and the gateway→backend connection-pool fix — are written up inREPORT.md. See../loadtest/README.md.
- a per-container resource profile) read off the otelcol
- User feedback —
internal/feedbackunit tests cover the attachment allow-list / content-type and the channel normaliser; the UI coversdetectChannel, the attachment gate and the feedback wire round-trip (channel/feedback/codectests) plus a Playwright e2e (submit → confirm + resend blocked; an operator reply raises the badge and shows on the screen). The gatewayconnectsrvtest asserts the guest gate (a guest'sfeedback.submit→guest_forbiddenwith no backend call; a non-gated authenticated op still passes). Postgres-backedinttestdrives the feedback lifecycle end to end: the guest / ban / pending gates, the reply read + one-week visibility window, the account-role grant/revoke, and the admin queue filters with delete / delete-all. The admin-console render test renders the feedback list + detail pages.
Principles
- A green run must not depend on cached state: use
-count=1in CI. - Tests that need infrastructure fail loudly (
t.Fatal) when it is unavailable rather than silently skipping coverage. - No network or real platform calls in unit tests; validate platform credentials behind an interface seam and test with fixtures.
Per-stage CI gate
Every completed stage is exercised on gitea.iliadenisov.ru before it is marked
done in ../PLAN.md:
- Commit the stage on its
feature/*branch. - Push to
origin. - Watch the run to completion — never hand-roll a poll loop:
python3 ~/.claude/bin/gitea-ci-watch.py(launch in the background). - Only after every workflow that fired is green may the stage be marked done.