fix(payments): a console refund that its own notification beat is not a repeat
CI / changes (pull_request) Successful in 2s
CI / unit (pull_request) Successful in 11s
CI / integration (pull_request) Successful in 22s
CI / ui (pull_request) Successful in 1m16s
CI / conformance (pull_request) Successful in 10s
CI / gate (pull_request) Successful in 1s
CI / deploy (pull_request) Successful in 2m28s

Refunding from /_gm reported "Already refunded" for a refund that had just
succeeded, which reads as "you clicked twice".

The two recording paths race. YooKassa fires refund.succeeded the moment
POST /v3/refunds returns, so the notification handler often writes the reversal
before the console's own write lands. Both name the same refund id, so the
ledger's idempotency index rejects the second — which is the mechanism working
exactly as intended: on the contour the money moved once, one refund row was
written, the balance is right and no abuse flag was raised. Only the message
was wrong about why.

The console now reports success on that path, and the notification's log line
no longer claims the refund was "issued outside the console" when it may well
have come from it.

Covered by an integration test that lands the notification first and then
refunds from the console, asserting the operator is told it succeeded and that
exactly one refund row exists.
This commit is contained in:
Ilia Denisov
2026-07-28 12:15:59 +02:00
parent 4cac09c9f3
commit e3961fe4ca
6 changed files with 71 additions and 1 deletions
@@ -49,6 +49,15 @@ func (s *Server) consoleRefund(c *gin.Context) {
return
}
if out.AlreadyRefunded {
if ref.Provider == providerYooKassa {
// The provider refunded the money on this very click, so this is a success, not a repeat.
// The reversal was already in the ledger because the provider's own refund notification
// reached us first — it names the same refund id, which is exactly why the idempotency
// index caught it and nothing was revoked twice. Saying "already refunded" here would read
// as "you clicked twice".
s.renderConsoleMessage(c, "Refunded", "the money is back with the customer; the reversal was already recorded, so nothing changed just now", back)
return
}
s.renderConsoleMessage(c, "Already refunded", "this order was already refunded", back)
return
}