fix(feedback): show the operator reply only on the player's latest message
CI / changes (pull_request) Successful in 2s
CI / unit (pull_request) Successful in 9s
CI / integration (pull_request) Successful in 13s
CI / ui (pull_request) Successful in 47s
CI / gate (pull_request) Successful in 0s
CI / deploy (pull_request) Successful in 1m8s
CI / changes (pull_request) Successful in 2s
CI / unit (pull_request) Successful in 9s
CI / integration (pull_request) Successful in 13s
CI / ui (pull_request) Successful in 47s
CI / gate (pull_request) Successful in 0s
CI / deploy (pull_request) Successful in 1m8s
A reply was bound to 'the latest message that has a reply', so after the player read a reply and sent a new (unanswered) message, the old reply kept showing as 'Ответ на ваше последнее сообщение'. Bind it to the single most-recent message instead: sending any new message immediately drops the previous reply (the new message has no reply yet), well before the one-week window. Client clears the reply optimistically on submit; the mock mirrors it; inttest covers the case.
This commit is contained in:
@@ -45,3 +45,16 @@ test('feedback: an operator reply raises the badge and shows on the screen', asy
|
||||
await expect(page.getByText('Reply to your last message')).toBeVisible();
|
||||
await expect(page.getByText(/looking into it/)).toBeVisible();
|
||||
});
|
||||
|
||||
test('feedback: sending a new message clears the previous reply', async ({ page }) => {
|
||||
await loginLobby(page);
|
||||
await page.evaluate(() => (window as unknown as { __mock: { adminReply(): void } }).__mock.adminReply());
|
||||
await openFeedback(page);
|
||||
await expect(page.getByText('Reply to your last message')).toBeVisible();
|
||||
|
||||
// A new message has no reply yet, so the previous reply must stop showing at once.
|
||||
await page.locator('textarea').fill('a follow-up question');
|
||||
await page.getByRole('button', { name: 'Send', exact: true }).click();
|
||||
await expect(page.getByText('Your message has been sent.')).toBeVisible();
|
||||
await expect(page.getByText('Reply to your last message')).toBeHidden();
|
||||
});
|
||||
|
||||
@@ -418,6 +418,7 @@ export class MockGateway implements GatewayClient {
|
||||
}
|
||||
async feedbackSubmit(_body: string, _attachment: Uint8Array | null, _attachmentName: string, _channel: string): Promise<void> {
|
||||
this.feedbackPending = true;
|
||||
this.feedbackReply = null; // a new message: the previous operator reply no longer shows
|
||||
}
|
||||
async feedbackGet(): Promise<FeedbackState> {
|
||||
this.feedbackReplyUnread = false; // fetching the screen delivers (reads) the reply
|
||||
|
||||
@@ -71,7 +71,8 @@
|
||||
removeFile();
|
||||
sent = true;
|
||||
// The message is now under review: block resending until the operator handles it.
|
||||
view = { canSend: false, blockedReason: 'pending', reply: view?.reply ?? null };
|
||||
// A new message has no reply yet, so the previous operator reply stops showing.
|
||||
view = { canSend: false, blockedReason: 'pending', reply: null };
|
||||
} catch (e) {
|
||||
handleError(e);
|
||||
} finally {
|
||||
|
||||
Reference in New Issue
Block a user