Ilia Denisov
4a23c357e5
Drains six F8 polish items (parent #43) in one feature: а) Chrome cleanup - п.6 — remove the AccountMenu (settings/sessions/theme/language/logout ∼ rudimentary in-game) and replace it with a single icon-button light/dark theme toggle. The toggle flips an in-memory `theme.override`; game-shell unmount calls `theme.clearOverride()` so the lobby (and any re-entry) re-projects the persisted lobby choice. - п.8 — remove the wrap-scrolling radio from the map gear popover. The per-game `wrapMode` store and the renderer's no-wrap path stay in place for a future engine-side topology feature; only the UI surface is dropped (wrap is a server-side concept, not a per-session UI affordance). б) Inspector compact rows (single idiom: select + ✓ apply / ✗ cancel, or contextual edit/remove/add) - п.13 — planet name is now click-to-edit: clicking the name opens an inline `<input>` + ✓ confirm icon; Escape cancels; the explicit Rename action button and Cancel button are gone. - п.14 — production becomes one row: primary `<select>` picks industry/materials/research/ship, conditional secondary `<select>` picks the target (tech / science / ship class) for research and ship contexts. Apply is gated until row state differs from the planet's current effective production; auto-submit-on-click is replaced by the apply-gate. - п.16 — cargo routes collapse to one row: a single dropdown (COL/CAP/MAT/EMP plus a placeholder that absorbs the old section title) and contextual action buttons (add / edit + remove) to the right. After a successful pick or remove the dropdown stays on the type the user just acted on. - п.32 — stationed ship groups hoist the race column into a dropdown above the table. The dropdown seeds with the player's own race when local groups are stationed here, otherwise the first race alphabetically; rendered only when more than one race is in orbit. The race column is dropped in both single- and multi-race modes — the dropdown's value already names the active race. Tests: unit and Playwright e2e updated for every changed test-id and flow; new coverage added for `theme.override`, the in-game toggle, the apply-gate behaviour, and the stationed-race dropdown. i18n keys for the removed menu items, the wrap radios, the cargo title, and the explicit `rename.cancel` are dropped from both locales; new `game.shell.theme_toggle.*`, `production.main/target.*`, `production.apply/cancel`, `cargo.placeholder`, and `ship_groups.race_filter.aria` keys land. Docs synced: `docs/FUNCTIONAL.md` §6.7 + `docs/FUNCTIONAL_ru.md` mirror drop the torus / no-wrap radio mention; `ui/docs/design-system.md` documents the lobby-owned persisted picker + the in-game ephemeral override channel. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
72 lines
2.6 KiB
TypeScript
72 lines
2.6 KiB
TypeScript
// F2 — keyboard-only navigation coverage for the in-game shell.
|
|
// Runs on chromium-desktop (a stable ≥1024px viewport where the sidebar
|
|
// is visible); the behaviours under test are engine-independent.
|
|
|
|
import { expect, test, type Page } from "@playwright/test";
|
|
|
|
const SESSION_ID = "f2-a11y-keyboard-session";
|
|
const GAME_ID = "10101010-1010-1010-1010-101010101010";
|
|
|
|
async function bootShell(page: Page): Promise<void> {
|
|
await page.goto("/__debug/store");
|
|
await expect(page.getByTestId("debug-store-ready")).toBeVisible();
|
|
await page.waitForFunction(() => window.__galaxyDebug?.ready === true);
|
|
await page.evaluate(() => window.__galaxyDebug!.clearSession());
|
|
await page.evaluate(
|
|
(id) => window.__galaxyDebug!.setDeviceSessionId(id),
|
|
SESSION_ID,
|
|
);
|
|
await page.goto("/");
|
|
await page.waitForFunction(() => window.__galaxyNav !== undefined);
|
|
await page.evaluate(
|
|
(id) => window.__galaxyNav!.enterGame(id, "map", {}),
|
|
GAME_ID,
|
|
);
|
|
await expect(page.getByTestId("game-shell")).toBeVisible();
|
|
await expect(page.getByTestId("active-view-map")).toBeVisible();
|
|
}
|
|
|
|
test.describe("keyboard navigation", () => {
|
|
test.beforeEach(({}, testInfo) => {
|
|
test.skip(
|
|
testInfo.project.name !== "chromium-desktop",
|
|
"keyboard specs run on chromium-desktop",
|
|
);
|
|
});
|
|
|
|
test("skip link is the first focusable and jumps to main content", async ({
|
|
page,
|
|
}) => {
|
|
await bootShell(page);
|
|
await page.keyboard.press("Tab");
|
|
await expect(page.locator(".skip-link")).toBeFocused();
|
|
await page.keyboard.press("Enter");
|
|
await expect(page.locator("#active-view-host")).toBeFocused();
|
|
});
|
|
|
|
test("game-mode theme toggle is keyboard activatable", async ({ page }) => {
|
|
await bootShell(page);
|
|
const toggle = page.getByTestId("game-mode-theme-toggle");
|
|
await toggle.focus();
|
|
await expect(toggle).toBeFocused();
|
|
const before = await toggle.getAttribute("data-theme");
|
|
await page.keyboard.press("Enter");
|
|
const after = await toggle.getAttribute("data-theme");
|
|
expect(after).not.toBe(before);
|
|
// The toggle keeps focus across an activation.
|
|
await expect(toggle).toBeFocused();
|
|
});
|
|
|
|
test("sidebar tabs move with the arrow keys (roving)", async ({ page }) => {
|
|
await bootShell(page);
|
|
const calculator = page.getByTestId("sidebar-tab-calculator");
|
|
const inspector = page.getByTestId("sidebar-tab-inspector");
|
|
await calculator.click();
|
|
await expect(calculator).toHaveAttribute("aria-selected", "true");
|
|
await calculator.focus();
|
|
await page.keyboard.press("ArrowRight");
|
|
await expect(inspector).toBeFocused();
|
|
await expect(inspector).toHaveAttribute("aria-selected", "true");
|
|
});
|
|
});
|