9d2504c42d
`time.LoadLocation` is called from
backend/internal/server/handlers_public_auth.go:108 (confirm-email-code)
and backend/internal/user/account.go:218 (user.settings.update). Both
runtime images shipped today have no tzdata — production
backend/Dockerfile uses gcr.io/distroless/static-debian12:nonroot, and
local-dev tools/local-dev/backend.Dockerfile uses alpine:3.20 without
the optional tzdata apk — so the container-side binary resolves only
the no-data fallback (UTC and fixed offsets) and rejects every real
IANA zone with HTTP 400 `invalid_request: time_zone must be a valid
IANA zone`.
Adding `import _ "time/tzdata"` to backend's main is the idiomatic
Go fix: the binary embeds the IANA database, time.LoadLocation works
on every base image, no Dockerfile changes needed. Cost is ~800 KB
of binary growth — invisible next to the existing /usr/local/bin/backend
size and well below any container layer threshold.
The OpenAPI spec already documents the field as "IANA time-zone
identifier" (gateway/openapi.yaml:205, backend/openapi.yaml:2334)
and the UI sends Intl.DateTimeFormat().resolvedOptions().timeZone,
so neither the contract nor the client needs a change.
Why this slipped through: backend unit tests run as a host Go test
process (developer's tzdata covers them), Playwright tests mock the
gateway (backend never reached), and the integration suite — the only
layer that exercises the real backend container — uses
RegisterSession which hardcoded `time_zone="UTC"`. Switching that
default to "Europe/Berlin" makes every integration scenario that
enrols a pilot exercise the tzdata path, so the next regression
surfaces in the integration run instead of escaping into manual
smoke. (The integration suite is not in the per-PR workflow yet; that
gap is tracked separately.)
Verified end-to-end against `tools/local-dev`:
- Europe/Amsterdam, Asia/Tokyo, America/Los_Angeles → 200 +
device_session_id (was 400 before this patch).
- Mars/Olympus still → 400 (validation behaviour unchanged).
Host tests: backend/internal/{auth,user,config} green.
UI: pnpm test 14/14, CI=1 pnpm exec playwright test 44/44.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
117 lines
3.5 KiB
Go
117 lines
3.5 KiB
Go
package testenv
|
|
|
|
import (
|
|
"context"
|
|
"crypto/ed25519"
|
|
"encoding/json"
|
|
"fmt"
|
|
"net/http"
|
|
"regexp"
|
|
"testing"
|
|
"time"
|
|
)
|
|
|
|
// Session is a registered device session ready to drive the
|
|
// authenticated edge surface.
|
|
type Session struct {
|
|
Email string
|
|
DeviceSessionID string
|
|
Public ed25519.PublicKey
|
|
Private ed25519.PrivateKey
|
|
}
|
|
|
|
var sessionLoginCodeRE = regexp.MustCompile(`(?m)\b(\d{6})\b`)
|
|
|
|
// RegisterSession runs send-email-code → confirm-email-code through
|
|
// the gateway public REST surface and returns a fresh Session. It
|
|
// uses mailpit to capture the verification code and includes the
|
|
// platform's mailpit reset to avoid stale messages between calls.
|
|
func RegisterSession(t *testing.T, plat *Platform, email string) *Session {
|
|
t.Helper()
|
|
ctx, cancel := context.WithTimeout(context.Background(), 60*time.Second)
|
|
defer cancel()
|
|
|
|
if err := plat.Mailpit.DeleteAll(ctx); err != nil {
|
|
t.Fatalf("clear mailpit: %v", err)
|
|
}
|
|
|
|
pub, priv, err := GenerateSessionKeyPair()
|
|
if err != nil {
|
|
t.Fatalf("generate session keypair: %v", err)
|
|
}
|
|
public := NewPublicRESTClient(plat.Gateway.HTTPURL)
|
|
|
|
send, _, err := public.SendEmailCode(ctx, email, "en-US")
|
|
if err != nil {
|
|
t.Fatalf("send-email-code: %v", err)
|
|
}
|
|
if send.ChallengeID == "" {
|
|
t.Fatalf("send-email-code returned empty challenge_id")
|
|
}
|
|
|
|
msg, err := plat.Mailpit.WaitForMessage(ctx, "to:"+email, 30*time.Second)
|
|
if err != nil {
|
|
t.Fatalf("wait for mail: %v", err)
|
|
}
|
|
body, err := plat.Mailpit.MessageBody(ctx, msg.ID)
|
|
if err != nil {
|
|
t.Fatalf("fetch mail body: %v", err)
|
|
}
|
|
m := sessionLoginCodeRE.FindStringSubmatch(body)
|
|
if m == nil {
|
|
t.Fatalf("no 6-digit code in mail body:\n%s", body)
|
|
}
|
|
code := m[1]
|
|
|
|
// Pass a non-UTC IANA zone so every integration scenario that
|
|
// enrols a pilot exercises the time.LoadLocation path. UTC works
|
|
// even when the backend image lacks tzdata (Go's no-data fallback
|
|
// covers it), so a regression that drops the embedded tzdata
|
|
// import would otherwise slip past unnoticed.
|
|
confirm, _, err := public.ConfirmEmailCode(ctx, send.ChallengeID, code, EncodePublicKey(pub), "Europe/Berlin")
|
|
if err != nil {
|
|
t.Fatalf("confirm-email-code: %v", err)
|
|
}
|
|
if confirm.DeviceSessionID == "" {
|
|
t.Fatalf("confirm-email-code returned empty device_session_id")
|
|
}
|
|
|
|
return &Session{
|
|
Email: email,
|
|
DeviceSessionID: confirm.DeviceSessionID,
|
|
Public: pub,
|
|
Private: priv,
|
|
}
|
|
}
|
|
|
|
// DialAuthenticated returns a SignedGatewayClient bound to s.
|
|
func (s *Session) DialAuthenticated(ctx context.Context, plat *Platform) (*SignedGatewayClient, error) {
|
|
if s == nil {
|
|
return nil, fmt.Errorf("nil session")
|
|
}
|
|
return DialGateway(ctx, plat.Gateway.GRPCAddr, s.DeviceSessionID, s.Private, plat.Gateway.ResponseSignerPublic)
|
|
}
|
|
|
|
// LookupUserID resolves the user_id for s via backend's internal
|
|
// session lookup. Returns an empty string if the session is unknown.
|
|
func (s *Session) LookupUserID(ctx context.Context, plat *Platform) (string, error) {
|
|
if s == nil || s.DeviceSessionID == "" {
|
|
return "", fmt.Errorf("nil or empty session")
|
|
}
|
|
internal := NewBackendInternalClient(plat.Backend.HTTPURL)
|
|
raw, resp, err := internal.Do(ctx, http.MethodGet, "/api/v1/internal/sessions/"+s.DeviceSessionID, nil)
|
|
if err != nil {
|
|
return "", err
|
|
}
|
|
if resp.StatusCode != http.StatusOK {
|
|
return "", fmt.Errorf("session lookup: status %d body=%s", resp.StatusCode, string(raw))
|
|
}
|
|
var body struct {
|
|
UserID string `json:"user_id"`
|
|
}
|
|
if err := json.Unmarshal(raw, &body); err != nil {
|
|
return "", fmt.Errorf("decode session: %w", err)
|
|
}
|
|
return body.UserID, nil
|
|
}
|