Ilia Denisov
658ab7f6e7
Tests · FBS codegen / codegen (push) Successful in 5s
Tests · Go / test (push) Successful in 2m29s
Tests · FBS codegen / codegen (pull_request) Successful in 6s
Tests · UI / test (push) Waiting to run
Tests · Integration / integration (pull_request) Successful in 1m46s
Tests · Go / test (pull_request) Successful in 3m20s
Tests · UI / test (pull_request) Successful in 3m19s
The committed FlatBuffers bindings were generated by flatc 25.x (the TS runtime is flatbuffers@25.9.23), but nothing pinned the compiler, so a regen on a box with an older flatc (Debian apt ships 23.5.26) silently churns output and flips nullable-scalar builder defaults. PR #82 hit this and shipped 5 report files from the wrong compiler. Unify the whole toolchain on 25.9.23 (the only version available as an npm package, a prebuilt flatc binary, and a Go tag) and make the bindings reproducible: - Downgrade the flatbuffers Go module 25.12.19 -> 25.9.23 (schema, transcoder, gateway, integration) so compiler and both runtimes match. - Regenerate every schema with flatc 25.9.23. The only resulting change is order/command-item.ts: the lone straggler still on the old optional-scalar builder default (cmd_applied/cmd_error_code: 0 -> null). Inert in practice — the TS side never builds those response-only fields (the engine sets them in Go); the reader is unchanged. - Pin the version in tooling: a flatc-check guard in ui/Makefile (fbs-ts) and a new pkg/schema/fbs/Makefile (fbs-go); both refuse a mismatched flatc and point at the release binary. Fix the stale apt install hint. - Add a path-filtered CI guard (.gitea/workflows/fbs-codegen.yaml) that regenerates with the pinned flatc and fails on any diff. - Document the pinned version and the regen commands in the schema README. No wire-format change: Go build/vet, transcoder roundtrip + engine tests, pnpm check and the full vitest suite (888) stay green.
27 lines
1.5 KiB
Makefile
27 lines
1.5 KiB
Makefile
.PHONY: help fbs-go flatc-check
|
|
|
|
# Pinned flatc version. The committed Go bindings under <schema>/ and the
|
|
# flatbuffers Go runtime (go.mod) are on this version; the TS side mirrors
|
|
# it via `make -C ui fbs-ts`. Generating with a different flatc silently
|
|
# churns output and can flip nullable-scalar wire defaults, so fbs-go
|
|
# refuses to run on a mismatch. Distro packages (e.g. Debian's
|
|
# flatbuffers-compiler) are too old — use the release binary at $(FLATC_URL).
|
|
REQUIRED_FLATC := 25.9.23
|
|
FLATC_URL := https://github.com/google/flatbuffers/releases/tag/v$(REQUIRED_FLATC)
|
|
# Every schema in this directory. Listed explicitly (not a wildcard) so a
|
|
# stray .fbs cannot silently change the generated set.
|
|
FBS_INPUTS := common.fbs lobby.fbs user.fbs report.fbs order.fbs diplomail.fbs battle.fbs gateway.fbs notification.fbs
|
|
|
|
help:
|
|
@echo "schema/fbs targets:"
|
|
@echo " fbs-go FlatBuffers Go generation from *.fbs into <schema>/ (requires flatc $(REQUIRED_FLATC))"
|
|
|
|
flatc-check:
|
|
@command -v flatc >/dev/null || { echo "flatc not found; install flatc $(REQUIRED_FLATC) from $(FLATC_URL) (distro packages such as Debian's flatbuffers-compiler are too old)"; exit 1; }
|
|
@flatc --version | grep -q "$(REQUIRED_FLATC)" || { echo "flatc $(REQUIRED_FLATC) required; found '$$(flatc --version)'. Get the pinned binary from $(FLATC_URL)"; exit 1; }
|
|
|
|
# --go-module-name rewrites cross-namespace imports to the fully-qualified
|
|
# module path so the generated code links without local replace directives.
|
|
fbs-go: flatc-check
|
|
flatc --go --go-module-name galaxy/schema/fbs $(FBS_INPUTS)
|