Files
galaxy-game/pkg/transcoder/order_test.go
T
Ilia Denisov 601970b028
Tests · Go / test (push) Successful in 2m27s
Tests · UI / test (push) Waiting to run
Tests · Integration / integration (pull_request) Successful in 1m45s
Tests · Go / test (pull_request) Successful in 3m13s
Tests · UI / test (pull_request) Successful in 3m8s
refactor(game): lock-free storage, remove /command, flatten engine wrapper
Three-stage refactor of the game-engine plumbing (game logic untouched):

Stage 1 — lock-free persistence + admin serialisation. Remove the file
lock from repo/fs (the .lock file, the Read/Write-vs-*Safe duality and the
dead ReadSafe polling) and replace the two-step rename with a single atomic
rename so concurrent reads are torn-free without a lock. Serialise the
state-mutating admin writers (init/turn/banish) with one shared router
LimitMiddleware, rewritten to block on the request context instead of a
racy shared 100ms timer.

Stage 2 — remove the obsolete immediate-command path end to end. Players
submit through PUT /api/v1/order; the legacy PUT /api/v1/command path is
deleted across game (route, handler, 24 command factories, Ctrl), backend
(Commands handler/route, engineclient.ExecuteCommands), gateway (dispatch +
executeUserGamesCommand + routing entry), the FlatBuffers/model contract
(UserGamesCommand[Response]) and transcoder, plus every affected
OpenAPI/README/FUNCTIONAL/ARCHITECTURE doc. The integration proxy test is
converted to the order path.

Stage 3 — flatten the REST->engine wrapper. Replace the executor adapter,
the controller package functions and RepoController with one concrete
controller.Service; drop the single-implementation Repo and Storage
interfaces (repo.Repo / fs.FS are now concrete). Handlers depend on a thin
handler.Engine seam and own the domain->REST projection; storage is
resolved once at startup instead of per request.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-05-30 13:37:07 +02:00

238 lines
6.1 KiB
Go

package transcoder
import (
"reflect"
"strconv"
"testing"
model "galaxy/model/order"
"github.com/google/uuid"
)
func TestUserGamesOrderPayloadRoundTrip(t *testing.T) {
t.Parallel()
source := &model.UserGamesOrder{
GameID: uuid.MustParse("aaaaaaaa-bbbb-cccc-dddd-eeeeeeeeeeee"),
UpdatedAt: 12345,
Commands: []model.DecodableCommand{
&model.CommandPlanetRename{CommandMeta: commandMeta("cmd-1", model.CommandTypePlanetRename, nil, nil), Number: 5, Name: "alpha"},
},
}
payload, err := UserGamesOrderToPayload(source)
if err != nil {
t.Fatalf("encode user games order: %v", err)
}
decoded, err := PayloadToUserGamesOrder(payload)
if err != nil {
t.Fatalf("decode user games order: %v", err)
}
if !reflect.DeepEqual(source, decoded) {
t.Fatalf("round-trip mismatch\nsource: %#v\ndecoded:%#v", source, decoded)
}
}
func TestUserGamesOrderRejectsNilAndEmpty(t *testing.T) {
t.Parallel()
if _, err := UserGamesOrderToPayload(nil); err == nil {
t.Fatalf("expected error encoding nil user games order")
}
if _, err := PayloadToUserGamesOrder(nil); err == nil {
t.Fatalf("expected error decoding empty user games order")
}
if _, err := UserGamesOrderGetToPayload(nil); err == nil {
t.Fatalf("expected error encoding nil user games order get")
}
if _, err := PayloadToUserGamesOrderGet(nil); err == nil {
t.Fatalf("expected error decoding empty user games order get")
}
if _, _, err := PayloadToUserGamesOrderGetResponse(nil); err == nil {
t.Fatalf("expected error decoding empty user games order get response")
}
}
func TestUserGamesOrderResponsePayloadRoundTrip(t *testing.T) {
t.Parallel()
applied := true
rejected := false
errCode := 7
errMsg := "rename failed: planet does not exist"
source := &model.UserGamesOrder{
GameID: uuid.MustParse("aaaaaaaa-bbbb-cccc-dddd-eeeeeeeeeeee"),
UpdatedAt: 99,
Commands: []model.DecodableCommand{
&model.CommandPlanetRename{
CommandMeta: commandMeta("cmd-1", model.CommandTypePlanetRename, &applied, nil),
Number: 5,
Name: "alpha",
},
&model.CommandPlanetRename{
CommandMeta: commandMetaWithMsg("cmd-2", model.CommandTypePlanetRename, &rejected, &errCode, &errMsg),
Number: 6,
Name: "beta",
},
},
}
payload, err := UserGamesOrderResponseToPayload(source)
if err != nil {
t.Fatalf("encode user games order response: %v", err)
}
decoded, err := PayloadToUserGamesOrderResponse(payload)
if err != nil {
t.Fatalf("decode user games order response: %v", err)
}
if !reflect.DeepEqual(source, decoded) {
t.Fatalf("round-trip mismatch\nsource: %#v\ndecoded:%#v", source, decoded)
}
}
func TestUserGamesOrderResponseEmptyPayload(t *testing.T) {
t.Parallel()
payload, err := UserGamesOrderResponseToPayload(nil)
if err != nil {
t.Fatalf("encode empty user games order response: %v", err)
}
if len(payload) == 0 {
t.Fatal("empty envelope payload must be non-zero length")
}
decoded, err := PayloadToUserGamesOrderResponse(payload)
if err != nil {
t.Fatalf("decode empty user games order response: %v", err)
}
if decoded != nil {
t.Fatalf("empty envelope must decode to nil, got %#v", decoded)
}
}
func TestUserGamesOrderGetPayloadRoundTrip(t *testing.T) {
t.Parallel()
source := &model.UserGamesOrderGet{
GameID: uuid.MustParse("11111111-2222-3333-4444-555555555555"),
Turn: 7,
}
payload, err := UserGamesOrderGetToPayload(source)
if err != nil {
t.Fatalf("encode user games order get: %v", err)
}
decoded, err := PayloadToUserGamesOrderGet(payload)
if err != nil {
t.Fatalf("decode user games order get: %v", err)
}
if !reflect.DeepEqual(source, decoded) {
t.Fatalf("round-trip mismatch\nsource: %#v\ndecoded:%#v", source, decoded)
}
}
func TestUserGamesOrderGetRejectsNegativeTurn(t *testing.T) {
t.Parallel()
if _, err := UserGamesOrderGetToPayload(&model.UserGamesOrderGet{
GameID: uuid.MustParse("11111111-2222-3333-4444-555555555555"),
Turn: -1,
}); err == nil {
t.Fatalf("expected error encoding negative turn")
}
}
func TestUserGamesOrderGetResponseRoundTrip(t *testing.T) {
t.Parallel()
applied := true
stored := &model.UserGamesOrder{
GameID: uuid.MustParse("aaaaaaaa-bbbb-cccc-dddd-eeeeeeeeeeee"),
UpdatedAt: 1234,
Commands: []model.DecodableCommand{
&model.CommandPlanetRename{
CommandMeta: commandMeta("cmd-1", model.CommandTypePlanetRename, &applied, nil),
Number: 5,
Name: "stored",
},
},
}
payload, err := UserGamesOrderGetResponseToPayload(stored, true)
if err != nil {
t.Fatalf("encode user games order get response: %v", err)
}
decoded, found, err := PayloadToUserGamesOrderGetResponse(payload)
if err != nil {
t.Fatalf("decode user games order get response: %v", err)
}
if !found {
t.Fatal("expected found=true round-trip")
}
if !reflect.DeepEqual(stored, decoded) {
t.Fatalf("round-trip mismatch\nsource: %#v\ndecoded:%#v", stored, decoded)
}
}
func TestUserGamesOrderGetResponseNotFound(t *testing.T) {
t.Parallel()
payload, err := UserGamesOrderGetResponseToPayload(nil, false)
if err != nil {
t.Fatalf("encode not-found response: %v", err)
}
decoded, found, err := PayloadToUserGamesOrderGetResponse(payload)
if err != nil {
t.Fatalf("decode not-found response: %v", err)
}
if found {
t.Fatal("expected found=false")
}
if decoded != nil {
t.Fatalf("expected nil order, got %#v", decoded)
}
}
func TestInt64ToInt(t *testing.T) {
t.Parallel()
value, err := int64ToInt(123, "field")
if err != nil {
t.Fatalf("unexpected error: %v", err)
}
if value != 123 {
t.Fatalf("unexpected int value: %d", value)
}
if strconv.IntSize == 32 {
maxInt := int(^uint(0) >> 1)
_, err = int64ToInt(int64(maxInt)+1, "field")
if err == nil {
t.Fatal("expected overflow error")
}
}
}
func commandMeta(id string, cmdType model.CommandType, applied *bool, errCode *int) model.CommandMeta {
return commandMetaWithMsg(id, cmdType, applied, errCode, nil)
}
func commandMetaWithMsg(id string, cmdType model.CommandType, applied *bool, errCode *int, errMsg *string) model.CommandMeta {
return model.CommandMeta{
CmdType: cmdType,
CmdID: id,
CmdApplied: applied,
CmdErrCode: errCode,
CmdErrMsg: errMsg,
}
}