Ilia Denisov
658ab7f6e7
Tests · FBS codegen / codegen (push) Successful in 5s
Tests · Go / test (push) Successful in 2m29s
Tests · FBS codegen / codegen (pull_request) Successful in 6s
Tests · UI / test (push) Waiting to run
Tests · Integration / integration (pull_request) Successful in 1m46s
Tests · Go / test (pull_request) Successful in 3m20s
Tests · UI / test (pull_request) Successful in 3m19s
The committed FlatBuffers bindings were generated by flatc 25.x (the TS runtime is flatbuffers@25.9.23), but nothing pinned the compiler, so a regen on a box with an older flatc (Debian apt ships 23.5.26) silently churns output and flips nullable-scalar builder defaults. PR #82 hit this and shipped 5 report files from the wrong compiler. Unify the whole toolchain on 25.9.23 (the only version available as an npm package, a prebuilt flatc binary, and a Go tag) and make the bindings reproducible: - Downgrade the flatbuffers Go module 25.12.19 -> 25.9.23 (schema, transcoder, gateway, integration) so compiler and both runtimes match. - Regenerate every schema with flatc 25.9.23. The only resulting change is order/command-item.ts: the lone straggler still on the old optional-scalar builder default (cmd_applied/cmd_error_code: 0 -> null). Inert in practice — the TS side never builds those response-only fields (the engine sets them in Go); the reader is unchanged. - Pin the version in tooling: a flatc-check guard in ui/Makefile (fbs-ts) and a new pkg/schema/fbs/Makefile (fbs-go); both refuse a mismatched flatc and point at the release binary. Fix the stale apt install hint. - Add a path-filtered CI guard (.gitea/workflows/fbs-codegen.yaml) that regenerates with the pinned flatc and fails on any diff. - Document the pinned version and the regen commands in the schema README. No wire-format change: Go build/vet, transcoder roundtrip + engine tests, pnpm check and the full vitest suite (888) stay green.
55 lines
3.1 KiB
Makefile
55 lines
3.1 KiB
Makefile
.PHONY: help web wasm ts-protos fbs-ts flatc-check gomobile desktop-mac desktop-win desktop-linux ios android all
|
|
|
|
.DEFAULT_GOAL := help
|
|
|
|
WASM_OUT := frontend/static/core.wasm
|
|
WASM_EXEC := frontend/static/wasm_exec.js
|
|
TINYGO_ROOT := $(shell tinygo env TINYGOROOT 2>/dev/null)
|
|
FBS_OUT := frontend/src/proto/galaxy/fbs
|
|
FBS_INPUTS := ../pkg/schema/fbs/common.fbs ../pkg/schema/fbs/lobby.fbs ../pkg/schema/fbs/user.fbs ../pkg/schema/fbs/report.fbs ../pkg/schema/fbs/order.fbs ../pkg/schema/fbs/diplomail.fbs ../pkg/schema/fbs/battle.fbs
|
|
# Pinned flatc version. The committed bindings (Go + TS) and the
|
|
# flatbuffers Go/TS runtimes are all on this version; generating with a
|
|
# different flatc silently churns output and can flip nullable-scalar
|
|
# wire defaults, so fbs-ts refuses to run on a mismatch. Distro packages
|
|
# (e.g. Debian's flatbuffers-compiler) are too old — use the release
|
|
# binary at $(FLATC_URL).
|
|
REQUIRED_FLATC := 25.9.23
|
|
FLATC_URL := https://github.com/google/flatbuffers/releases/tag/v$(REQUIRED_FLATC)
|
|
|
|
help:
|
|
@echo "ui targets:"
|
|
@echo " wasm TinyGo build of ui/core to core.wasm + wasm_exec.js shim (Phase 5)"
|
|
@echo " ts-protos Connect-ES + Protobuf-ES generation from gateway/proto (Phase 5)"
|
|
@echo " fbs-ts FlatBuffers TS generation from pkg/schema/fbs/*.fbs (requires flatc $(REQUIRED_FLATC))"
|
|
@echo " web Vite production build (Phase 5+)"
|
|
@echo " gomobile gomobile bind for iOS .framework + Android .aar (Phase 32+)"
|
|
@echo " desktop-mac Wails build for darwin/{arm64,amd64} (Phase 31)"
|
|
@echo " desktop-win Wails build for windows/amd64 (Phase 31)"
|
|
@echo " desktop-linux Wails build for linux/amd64 (Phase 31)"
|
|
@echo " ios Capacitor sync + xcodebuild + archive (Phase 32+)"
|
|
@echo " android Capacitor sync + gradle assembleRelease (Phase 32+)"
|
|
@echo " all every target above"
|
|
|
|
wasm:
|
|
@command -v tinygo >/dev/null || { echo "tinygo not found; install via 'brew install tinygo' (see ui/docs/wasm-toolchain.md)"; exit 1; }
|
|
tinygo build -o $(WASM_OUT) -target=wasm ./wasm
|
|
cp $(TINYGO_ROOT)/targets/wasm_exec.js $(WASM_EXEC)
|
|
@printf "core.wasm: %s\n" "$$(ls -lh $(WASM_OUT) | awk '{print $$5}')"
|
|
|
|
ts-protos:
|
|
@command -v buf >/dev/null || { echo "buf not found; install via 'brew install bufbuild/buf/buf' or see https://buf.build/docs/installation"; exit 1; }
|
|
@test -x frontend/node_modules/.bin/protoc-gen-es || { echo "protoc-gen-es not installed; run 'pnpm install' inside ui/frontend"; exit 1; }
|
|
buf generate ../gateway --template buf.gen.yaml --include-imports
|
|
|
|
flatc-check:
|
|
@command -v flatc >/dev/null || { echo "flatc not found; install flatc $(REQUIRED_FLATC) from $(FLATC_URL) (distro packages such as Debian's flatbuffers-compiler are too old)"; exit 1; }
|
|
@flatc --version | grep -q "$(REQUIRED_FLATC)" || { echo "flatc $(REQUIRED_FLATC) required; found '$$(flatc --version)'. Get the pinned binary from $(FLATC_URL)"; exit 1; }
|
|
|
|
fbs-ts: flatc-check
|
|
mkdir -p $(FBS_OUT)
|
|
flatc --ts --gen-object-api -o $(FBS_OUT) $(FBS_INPUTS)
|
|
|
|
web gomobile desktop-mac desktop-win desktop-linux ios android all:
|
|
@echo "TODO: implement '$@' (placeholder, see ui/PLAN.md)"
|
|
@exit 1
|