Ilia Denisov
ce7a66b3e6
Replaces the Phase 10 map stub with live planet rendering driven by `user.games.report`, and wires the header turn counter to the same data. Phase 11's frontend sits on a per-game `GameStateStore` that lives in `lib/game-state.svelte.ts`: the in-game shell layout instantiates one per game, exposes it through Svelte context, and disposes it on remount. The store discovers the game's current turn through `lobby.my.games.list`, fetches the matching report, and exposes a TS-friendly snapshot to the header turn counter, the map view, and the inspector / order / calculator tabs that later phases will plug onto the same instance. The pipeline forced one cross-stage decision: the user surface needs the current turn number to know which report to fetch, but `GameSummary` did not expose it. Phase 11 extends the lobby catalogue (FB schema, transcoder, Go model, backend gameSummaryWire, gateway decoders, openapi, TS bindings, api/lobby.ts) with `current_turn:int32`. The data was already tracked in backend's `RuntimeSnapshot.CurrentTurn`; surfacing it is a wire change only. Two alternatives were rejected: a brand-new `user.games.state` message (full wire-flow for one field) and hard-coding `turn=0` (works for the dev sandbox, which never advances past zero, but renders the initial state for any real game). The change crosses Phase 8's already-shipped catalogue per the project's "decisions baked back into the live plan" rule — existing tests and fixtures are updated in the same patch. The state binding lives in `map/state-binding.ts::reportToWorld`: one Point primitive per planet across all four kinds (local / other / uninhabited / unidentified) with distinct fill colours, fill alphas, and point radii so the user can tell them apart at a glance. The planet engine number is reused as the primitive id so a hit-test result resolves directly to a planet without an extra lookup table. Zero-planet reports yield a well-formed empty world; malformed dimensions fall back to 1×1 so a bad report cannot crash the renderer. The map view's mount effect creates the renderer once and skips re-mount on no-op refreshes (same turn, same wrap mode); a turn change or wrap-mode flip disposes and recreates it. The renderer's external API does not yet expose `setWorld`; Phase 24 / 34 will extract it once high-frequency updates land. The store installs a `visibilitychange` listener that calls `refresh()` when the tab regains focus. Wrap-mode preference uses `Cache` namespace `game-prefs`, key `<gameId>/wrap-mode`, default `torus`. Phase 11 reads through `store.wrapMode`; Phase 29 wires the toggle UI on top of `setWrapMode`. Tests: Vitest unit coverage for `reportToWorld` (every kind, ids, styling, empty / zero-dimension edges, priority order) and for the store lifecycle (init success, missing-membership error, forbidden-result error, `setTurn`, wrap-mode persistence across instances, `failBootstrap`). Playwright e2e mocks the gateway for `lobby.my.games.list` and `user.games.report` and asserts the live data path: turn counter shows the reported turn, `active-view-map` flips to `data-status="ready"`, and `data-planet-count` matches the fixture count. The zero-planet regression and the missing-membership error path are covered. Phase 11 status stays `pending` in `ui/PLAN.md` until the local-ci run lands green; flipping to `done` follows in the next commit per the per-stage CI gate in `CLAUDE.md`. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
91 lines
3.5 KiB
TypeScript
91 lines
3.5 KiB
TypeScript
// Component tests for every Phase 10 active-view stub. Each stub
|
|
// renders the localised view title plus the `coming soon` body copy
|
|
// and exposes a stable `data-testid` so later phases can replace the
|
|
// content without renaming the test hook. The table stub additionally
|
|
// honours its `entity` prop and falls back to the snake_case i18n key
|
|
// for an unknown slug.
|
|
|
|
import "@testing-library/jest-dom/vitest";
|
|
import { render } from "@testing-library/svelte";
|
|
import { beforeEach, describe, expect, test } from "vitest";
|
|
|
|
import { i18n } from "../src/lib/i18n/index.svelte";
|
|
|
|
import MapView from "../src/lib/active-view/map.svelte";
|
|
import TableView from "../src/lib/active-view/table.svelte";
|
|
import ReportView from "../src/lib/active-view/report.svelte";
|
|
import BattleView from "../src/lib/active-view/battle.svelte";
|
|
import MailView from "../src/lib/active-view/mail.svelte";
|
|
import DesignerShipClass from "../src/lib/active-view/designer-ship-class.svelte";
|
|
import DesignerScience from "../src/lib/active-view/designer-science.svelte";
|
|
|
|
beforeEach(() => {
|
|
i18n.resetForTests("en");
|
|
});
|
|
|
|
describe("active-view stubs", () => {
|
|
test("map view renders loading overlay when no game-state context is provided", () => {
|
|
// The live integration in `lib/active-view/map.svelte` (Phase 11)
|
|
// reads its data from a `GameStateStore` provided through context
|
|
// by `routes/games/[id]/+layout.svelte`. Without the context the
|
|
// store reference is `undefined` and the view stays in the
|
|
// `idle` branch, surfacing the localised loading overlay so the
|
|
// shell never renders an empty active-view slot.
|
|
const ui = render(MapView);
|
|
const node = ui.getByTestId("active-view-map");
|
|
expect(node).toHaveAttribute("data-status", "idle");
|
|
expect(ui.getByTestId("map-loading")).toBeInTheDocument();
|
|
expect(ui.getByTestId("map-canvas-wrap")).toBeInTheDocument();
|
|
});
|
|
|
|
test("table stub maps a kebab-case entity to the right i18n title", () => {
|
|
const ui = render(TableView, { props: { entity: "ship-classes" } });
|
|
const node = ui.getByTestId("active-view-table");
|
|
expect(node).toHaveAttribute("data-entity", "ship-classes");
|
|
expect(node).toHaveTextContent("ship classes");
|
|
expect(node).toHaveTextContent("coming soon");
|
|
});
|
|
|
|
test("table stub also handles a single-word entity", () => {
|
|
const ui = render(TableView, { props: { entity: "planets" } });
|
|
expect(ui.getByTestId("active-view-table")).toHaveTextContent("planets");
|
|
});
|
|
|
|
test("report / mail / designer stubs render their localised titles", () => {
|
|
const r = render(ReportView);
|
|
expect(r.getByTestId("active-view-report")).toHaveTextContent(
|
|
"turn report",
|
|
);
|
|
|
|
const m = render(MailView);
|
|
expect(m.getByTestId("active-view-mail")).toHaveTextContent(
|
|
"diplomatic mail",
|
|
);
|
|
|
|
const sc = render(DesignerShipClass);
|
|
expect(
|
|
sc.getByTestId("active-view-designer-ship-class"),
|
|
).toHaveTextContent("ship-class designer");
|
|
|
|
const sci = render(DesignerScience);
|
|
expect(
|
|
sci.getByTestId("active-view-designer-science"),
|
|
).toHaveTextContent("science designer");
|
|
});
|
|
|
|
test("battle stub stamps the battleId on the host element", () => {
|
|
const ui = render(BattleView, { props: { battleId: "b-42" } });
|
|
const node = ui.getByTestId("active-view-battle");
|
|
expect(node).toHaveAttribute("data-battle-id", "b-42");
|
|
expect(node).toHaveTextContent("battle log");
|
|
});
|
|
|
|
test("battle stub accepts an empty battleId for the list URL", () => {
|
|
const ui = render(BattleView, { props: { battleId: "" } });
|
|
expect(ui.getByTestId("active-view-battle")).toHaveAttribute(
|
|
"data-battle-id",
|
|
"",
|
|
);
|
|
});
|
|
});
|