feat(ui): F8-11 — battles table under table submenu (#54) #69

2026-05-27T20:16:34Z

developer commented

2026-05-27 20:16:34 +00:00

Summary

Adds the battles entity under the existing view → table submenu — a sortable list with planet (via planetLabel) and shots (from BattleSummary), default sort shots ↓. Row click hands off to the existing BattleViewer.
Removes the dead-end top-level battle log shortcut (it always rendered the battle not found placeholder) from both header/view-menu.svelte and sidebar/bottom-tabs.svelte. The single-battle viewer stays put — it is now reached only by clicking a row or a map battle marker.
No FBS / backend / map-marker changes. Participants / observers / total mass live only in the per-battle BattleReport; pulling them per row would mean N round trips per menu open, so by owner decision they are out of scope here.

Closes #54.

Test plan

npm run check
npm run test — 863 / 863 pass (new tests/table-battles.test.ts + updated tests/game-shell-header.test.ts + updated tests/e2e/game-shell.spec.ts)
npm run build
Gitea Actions: ui-test.yaml run 472 → success on feature/issue-54-battles-table
Manual sign-off in the dev environment after merge (or on a workflow_dispatch dev-deploy of this branch, on request)

## Summary - Adds the `battles` entity under the existing `view → table` submenu — a sortable list with **planet** (via `planetLabel`) and **shots** (from `BattleSummary`), default sort shots ↓. Row click hands off to the existing `BattleViewer`. - Removes the dead-end top-level `battle log` shortcut (it always rendered the `battle not found` placeholder) from both `header/view-menu.svelte` and `sidebar/bottom-tabs.svelte`. The single-battle viewer stays put — it is now reached only by clicking a row or a map battle marker. - No FBS / backend / map-marker changes. Participants / observers / total mass live only in the per-battle `BattleReport`; pulling them per row would mean N round trips per menu open, so by owner decision they are out of scope here. Closes #54. ## Test plan - [x] `npm run check` - [x] `npm run test` — 863 / 863 pass (new `tests/table-battles.test.ts` + updated `tests/game-shell-header.test.ts` + updated `tests/e2e/game-shell.spec.ts`) - [x] `npm run build` - [x] Gitea Actions: `ui-test.yaml` run 472 → success on `feature/issue-54-battles-table` - [ ] Manual sign-off in the dev environment after merge (or on a `workflow_dispatch` dev-deploy of this branch, on request)

developer added 1 commit 2026-05-27 20:16:34 +00:00

feat(ui): F8-11 — battles table under table submenu (#54 )

Tests · UI / test (push) Successful in 2m53s

Details

Tests · UI / test (pull_request) Successful in 3m0s

Details

209f8508cd

Adds a sortable battles list as a new entity under the existing
`view → table` submenu (entity slug `battles`), replacing the
standalone top-level `battle log` shortcut which always opened a
"battle not found" placeholder. The single-battle viewer stays put
and is reached only by clicking a row (or a battle marker on the
map), identical to the existing `section-battles.svelte` flow.

Columns are planet (via the shared `planetLabel` helper) and shots
(the per-battle action count carried by `BattleSummary`), sortable
both ways with shots-desc default. No backend / FBS / map changes:
the wire payload is unchanged. Participants / observers / total
mass require the full BattleReport and were intentionally dropped
to avoid N round trips per menu open.

The top-level `battle log` item is removed from `header/view-menu`
and `sidebar/bottom-tabs` (and their stale comment blocks updated);
the now-orphan `game.view.battle` i18n key is dropped from both
locales.

owner approved these changes 2026-05-27 20:29:25 +00:00

developer merged commit ba93a9092e into development

2026-05-27 20:29:52 +00:00

developer deleted branch feature/issue-54-battles-table

2026-05-27 20:29:52 +00:00

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: developer/galaxy-game#69