developer/galaxy-game
1
1
Fork 0
Code Issues Pull Requests Actions Packages Releases Wiki Activity

fix(ui): F8-08 unified number format — mono, fixed 3-decimal, no separators
Tests · UI / test (push) Waiting to run
Details
Tests · UI / test (pull_request) Waiting to run
Details

Browse Source 
Engine emits Floats at Fixed3 quantisation; UI now renders them as 3-decimal
fixed-point strings without thousand separators, monospaced via var(--font-mono)
on .numeric cells, and right-aligned in tables so columns line up on the
decimal point. Integer counts render with 0 decimals and no separators;
science fractions render as 1-decimal percent (matches the engine's third
decimal of precision).

Bug fixes from #51 (umbrella #43):
  - Player Status drive/weapons/shields/cargo: were tech LEVELS rendered
    through formatPercent (x100) — now use formatFloat (raw level).
  - Races table: same bug, same fix.

Style/UX cleanups:
  - Inspector field labels lose "stockpile" word ($ / M suffix carries it).
  - Coordinates drop the parentheses (just "x, y").
  - Inspector + report tables unify font sizes with calculator-tab
    (values 0.85rem mono, labels 0.8rem).

Files:
  - new util: ui/frontend/src/lib/util/number-format.ts
  - report/format.ts becomes a thin re-export to keep section imports compact
  - inspector planet / ship-group / actions: drop inline formatNumber,
    mark numeric <dd> with class="numeric"
  - table-races (+ bug fix), table-sciences, table-ship-classes,
    designer-science: drop inline formatters, switch to util, add
    class="numeric" on numeric <th>/<td>
  - 17 report section files: class="numeric" on numeric th/td +
    scoped CSS rule for mono+right-align
  - i18n en/ru: drop "stockpile" word, drop "%" from tech-level column
    headers in races + player_status (the "%" was the misleading bit
    from the bug)
  - tests/inspector-planet + tests/table-races: update assertions to
    match the new format

Verification: pnpm test (814 passed), pnpm check (0 errors/warnings),
pnpm build clean.

Refs: #51 (#43 umbrella).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Ilia Denisov
2026-05-27 11:08:22 +02:00
parent 208d30073b
commit b31d9f4c45
33 changed files with 484 additions and 379 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ui/frontend/tests/inspector-planet.test.ts
+2 -2
View File
@@ -87,7 +87,7 @@ describe("planet inspector", () => {
);
expect(
ui.getByTestId("inspector-planet-field-coordinates"),
).toHaveTextContent("(100.25, 200)");
).toHaveTextContent("100.250, 200.000");
expect(ui.getByTestId("inspector-planet-field-size")).toHaveTextContent(
"size",
);
@@ -240,7 +240,7 @@ describe("planet inspector", () => {
);
expect(
ui.getByTestId("inspector-planet-field-coordinates"),
).toHaveTextContent("(1,234, -5)");
).toHaveTextContent("1234.000, -5.000");
expect(ui.queryByTestId("inspector-planet-field-size")).toBeNull();
expect(ui.queryByTestId("inspector-planet-field-natural_resources")).toBeNull();
});
ui/frontend/tests/table-races.test.ts
+9 -11
View File
@@ -175,18 +175,16 @@ describe("races table", () => {
expect(rows).toHaveLength(1);
expect(rows[0]).toHaveAttribute("data-name", "Andori");
expect(ui.getByTestId("races-cell-name")).toHaveTextContent("Andori");
expect(ui.getByTestId("races-cell-drive")).toHaveTextContent("25");
expect(ui.getByTestId("races-cell-weapons")).toHaveTextContent("50");
expect(ui.getByTestId("races-cell-shields")).toHaveTextContent("75");
expect(ui.getByTestId("races-cell-cargo")).toHaveTextContent("100");
expect(ui.getByTestId("races-cell-population")).toHaveTextContent(
/12[,\s]345/,
);
expect(ui.getByTestId("races-cell-industry")).toHaveTextContent(
/6[,\s]?789/,
);
// drive/weapons/shields/cargo are tech LEVELS from the engine
// (see F8-08 bugfix); rendered as 3-decimal Floats, not percents.
expect(ui.getByTestId("races-cell-drive")).toHaveTextContent("0.250");
expect(ui.getByTestId("races-cell-weapons")).toHaveTextContent("0.500");
expect(ui.getByTestId("races-cell-shields")).toHaveTextContent("0.750");
expect(ui.getByTestId("races-cell-cargo")).toHaveTextContent("1.000");
expect(ui.getByTestId("races-cell-population")).toHaveTextContent("12345");
expect(ui.getByTestId("races-cell-industry")).toHaveTextContent("6789");
expect(ui.getByTestId("races-cell-planets")).toHaveTextContent("4");
expect(ui.getByTestId("races-cell-votes")).toHaveTextContent("3.5");
expect(ui.getByTestId("races-cell-votes")).toHaveTextContent("3.500");
});
test("filters rows by case-insensitive name match", async () => {