feat: game lobby service

2026-04-25 23:20:55 +02:00
parent 32dc29359a
commit 48b0056b49
336 changed files with 57074 additions and 1418 deletions
@@ -0,0 +1,259 @@
+// Package removemember implements the `lobby.membership.remove` message
+// type. Before the game has reached the running engine slot the
+// membership record is dropped from the store and the race name
+// reservation is released; after the engine slot exists the membership
+// transitions to `removed` and the reservation is preserved so the
+// capability evaluator at game finish can resolve it.
+package removemember
+
+import (
+	"context"
+	"errors"
+	"fmt"
+	"log/slog"
+	"time"
+
+	"galaxy/lobby/internal/domain/common"
+	"galaxy/lobby/internal/domain/game"
+	"galaxy/lobby/internal/domain/membership"
+	"galaxy/lobby/internal/logging"
+	"galaxy/lobby/internal/ports"
+	"galaxy/lobby/internal/service/shared"
+	"galaxy/lobby/internal/telemetry"
+)
+
+// preStartStatuses enumerates the game statuses in which a membership
+// may exist but the engine container slot does not. Removing in these
+// statuses drops the membership outright and releases the reservation.
+var preStartStatuses = map[game.Status]struct{}{
+	game.StatusEnrollmentOpen: {},
+	game.StatusReadyToStart:   {},
+	game.StatusStarting:       {},
+	game.StatusStartFailed:    {},
+}
+
+// postStartStatuses enumerates the game statuses in which the engine
+// container slot is alive. Removing in these statuses transitions the
+// membership to `removed` and keeps the reservation until the
+// capability evaluator runs at `game_finished`.
+var postStartStatuses = map[game.Status]struct{}{
+	game.StatusRunning: {},
+	game.StatusPaused:  {},
+}
+
+// Service executes the remove-member use case.
+type Service struct {
+	games       ports.GameStore
+	memberships ports.MembershipStore
+	directory   ports.RaceNameDirectory
+	clock       func() time.Time
+	logger      *slog.Logger
+	telemetry   *telemetry.Runtime
+}
+
+// Dependencies groups the collaborators used by Service.
+type Dependencies struct {
+	// Games loads the game record so the service can branch on
+	// game.Status and authorize the actor against the owner.
+	Games ports.GameStore
+
+	// Memberships persists the post-start status transition and the
+	// pre-start drop.
+	Memberships ports.MembershipStore
+
+	// Directory releases the race name reservation in the pre-start
+	// branch. The post-start branch never invokes Directory.
+	Directory ports.RaceNameDirectory
+
+	// Clock supplies the wall-clock used for the RemovedAt stamp.
+	// Defaults to time.Now when nil.
+	Clock func() time.Time
+
+	// Logger records structured service-level events. Defaults to
+	// slog.Default when nil.
+	Logger *slog.Logger
+
+	// Telemetry records the `lobby.membership.changes` counter on each
+	// successful removal. Optional; nil disables metric emission.
+	Telemetry *telemetry.Runtime
+}
+
+// NewService constructs one Service with deps.
+func NewService(deps Dependencies) (*Service, error) {
+	switch {
+	case deps.Games == nil:
+		return nil, errors.New("new remove member service: nil game store")
+	case deps.Memberships == nil:
+		return nil, errors.New("new remove member service: nil membership store")
+	case deps.Directory == nil:
+		return nil, errors.New("new remove member service: nil race name directory")
+	}
+
+	clock := deps.Clock
+	if clock == nil {
+		clock = time.Now
+	}
+	logger := deps.Logger
+	if logger == nil {
+		logger = slog.Default()
+	}
+
+	return &Service{
+		games:       deps.Games,
+		memberships: deps.Memberships,
+		directory:   deps.Directory,
+		clock:       clock,
+		logger:      logger.With("service", "lobby.removemember"),
+		telemetry:   deps.Telemetry,
+	}, nil
+}
+
+// Input stores the arguments required to remove one membership.
+type Input struct {
+	// Actor identifies the caller.
+	Actor shared.Actor
+
+	// GameID identifies the game referenced by the request path; it
+	// must match the loaded membership's GameID.
+	GameID common.GameID
+
+	// MembershipID identifies the target membership.
+	MembershipID common.MembershipID
+}
+
+// Handle authorizes the actor, asserts the membership belongs to the
+// game, branches on the game status to either drop or transition the
+// membership, and returns the post-removal record. The pre-start
+// branch returns a synthesized record with status=removed because the
+// underlying primary record has been deleted from the store.
+func (service *Service) Handle(ctx context.Context, input Input) (membership.Membership, error) {
+	if service == nil {
+		return membership.Membership{}, errors.New("remove member: nil service")
+	}
+	if ctx == nil {
+		return membership.Membership{}, errors.New("remove member: nil context")
+	}
+	if err := input.Actor.Validate(); err != nil {
+		return membership.Membership{}, fmt.Errorf("remove member: actor: %w", err)
+	}
+	if err := input.GameID.Validate(); err != nil {
+		return membership.Membership{}, fmt.Errorf("remove member: %w", err)
+	}
+	if err := input.MembershipID.Validate(); err != nil {
+		return membership.Membership{}, fmt.Errorf("remove member: %w", err)
+	}
+
+	member, err := service.memberships.Get(ctx, input.MembershipID)
+	if err != nil {
+		return membership.Membership{}, fmt.Errorf("remove member: %w", err)
+	}
+	if member.GameID != input.GameID {
+		return membership.Membership{}, fmt.Errorf(
+			"remove member: membership %q does not belong to game %q: %w",
+			member.MembershipID, input.GameID, membership.ErrNotFound,
+		)
+	}
+
+	gameRecord, err := service.games.Get(ctx, member.GameID)
+	if err != nil {
+		return membership.Membership{}, fmt.Errorf("remove member: %w", err)
+	}
+	if err := authorize(input.Actor, gameRecord); err != nil {
+		return membership.Membership{}, err
+	}
+
+	if member.Status != membership.StatusActive {
+		return membership.Membership{}, fmt.Errorf(
+			"remove member: status %q is not %q: %w",
+			member.Status, membership.StatusActive, membership.ErrConflict,
+		)
+	}
+
+	_, preStart := preStartStatuses[gameRecord.Status]
+	_, postStart := postStartStatuses[gameRecord.Status]
+	if !preStart && !postStart {
+		return membership.Membership{}, fmt.Errorf(
+			"remove member: game status %q does not allow remove: %w",
+			gameRecord.Status, game.ErrConflict,
+		)
+	}
+
+	now := service.clock().UTC()
+
+	if postStart {
+		if err := service.memberships.UpdateStatus(ctx, ports.UpdateMembershipStatusInput{
+			MembershipID: member.MembershipID,
+			ExpectedFrom: membership.StatusActive,
+			To:           membership.StatusRemoved,
+			At:           now,
+		}); err != nil {
+			return membership.Membership{}, fmt.Errorf("remove member: %w", err)
+		}
+		service.telemetry.RecordMembershipChange(ctx, "removed")
+		updated, err := service.memberships.Get(ctx, member.MembershipID)
+		if err != nil {
+			return membership.Membership{}, fmt.Errorf("remove member: %w", err)
+		}
+		logArgs := []any{
+			"game_id", gameRecord.GameID.String(),
+			"game_status", string(gameRecord.Status),
+			"membership_id", member.MembershipID.String(),
+			"user_id", member.UserID,
+			"trigger", "post_start",
+			"actor_kind", string(input.Actor.Kind),
+		}
+		logArgs = append(logArgs, logging.ContextAttrs(ctx)...)
+		service.logger.InfoContext(ctx, "member removed (post-start)", logArgs...)
+		return updated, nil
+	}
+
+	if err := service.memberships.Delete(ctx, member.MembershipID); err != nil {
+		return membership.Membership{}, fmt.Errorf("remove member: %w", err)
+	}
+	if err := service.directory.ReleaseReservation(
+		ctx,
+		gameRecord.GameID.String(),
+		member.UserID,
+		member.RaceName,
+	); err != nil {
+		// The directory contract states ReleaseReservation is a no-op
+		// for missing / mismatched / invalid records, so a non-nil
+		// error here is unexpected. Log and proceed — the membership
+		// record is already gone.
+		service.logger.WarnContext(ctx, "release reservation on pre-start remove",
+			"membership_id", member.MembershipID.String(),
+			"err", err.Error(),
+		)
+	}
+
+	service.telemetry.RecordMembershipChange(ctx, "removed")
+
+	logArgs := []any{
+		"game_id", gameRecord.GameID.String(),
+		"game_status", string(gameRecord.Status),
+		"membership_id", member.MembershipID.String(),
+		"user_id", member.UserID,
+		"trigger", "pre_start",
+		"actor_kind", string(input.Actor.Kind),
+	}
+	logArgs = append(logArgs, logging.ContextAttrs(ctx)...)
+	service.logger.InfoContext(ctx, "member removed (pre-start drop)", logArgs...)
+
+	removedAt := now
+	synthesized := member
+	synthesized.Status = membership.StatusRemoved
+	synthesized.RemovedAt = &removedAt
+	return synthesized, nil
+}
+
+// authorize enforces admin OR private-owner access to the record.
+func authorize(actor shared.Actor, record game.Game) error {
+	if actor.IsAdmin() {
+		return nil
+	}
+	if record.GameType == game.GameTypePrivate && actor.UserID == record.OwnerUserID {
+		return nil
+	}
+	return fmt.Errorf("%w: actor is not authorized to remove members from game %q",
+		shared.ErrForbidden, record.GameID.String())
+}
@@ -0,0 +1,425 @@
+package removemember_test
+
+import (
+	"context"
+	"io"
+	"log/slog"
+	"strings"
+	"testing"
+	"time"
+
+	"galaxy/lobby/internal/adapters/gamestub"
+	"galaxy/lobby/internal/adapters/membershipstub"
+	"galaxy/lobby/internal/adapters/racenamestub"
+	"galaxy/lobby/internal/domain/common"
+	"galaxy/lobby/internal/domain/game"
+	"galaxy/lobby/internal/domain/membership"
+	"galaxy/lobby/internal/ports"
+	"galaxy/lobby/internal/service/removemember"
+	"galaxy/lobby/internal/service/shared"
+
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+)
+
+func silentLogger() *slog.Logger {
+	return slog.New(slog.NewTextHandler(io.Discard, nil))
+}
+
+func fixedClock(at time.Time) func() time.Time {
+	return func() time.Time { return at }
+}
+
+type fixtures struct {
+	games       *gamestub.Store
+	memberships *membershipstub.Store
+	directory   *racenamestub.Directory
+}
+
+func newFixtures(t *testing.T) *fixtures {
+	t.Helper()
+
+	directory, err := racenamestub.NewDirectory()
+	require.NoError(t, err)
+
+	return &fixtures{
+		games:       gamestub.NewStore(),
+		memberships: membershipstub.NewStore(),
+		directory:   directory,
+	}
+}
+
+func (f *fixtures) newService(t *testing.T, clock func() time.Time) *removemember.Service {
+	t.Helper()
+
+	svc, err := removemember.NewService(removemember.Dependencies{
+		Games:       f.games,
+		Memberships: f.memberships,
+		Directory:   f.directory,
+		Clock:       clock,
+		Logger:      silentLogger(),
+	})
+	require.NoError(t, err)
+	return svc
+}
+
+func (f *fixtures) seedGame(
+	t *testing.T,
+	id common.GameID,
+	gameType game.GameType,
+	ownerUserID string,
+	status game.Status,
+	now time.Time,
+) game.Game {
+	t.Helper()
+
+	record, err := game.New(game.NewGameInput{
+		GameID:              id,
+		GameName:            "test remove",
+		GameType:            gameType,
+		OwnerUserID:         ownerUserID,
+		MinPlayers:          2,
+		MaxPlayers:          4,
+		StartGapHours:       4,
+		StartGapPlayers:     1,
+		EnrollmentEndsAt:    now.Add(24 * time.Hour),
+		TurnSchedule:        "0 */6 * * *",
+		TargetEngineVersion: "1.0.0",
+		Now:                 now,
+	})
+	require.NoError(t, err)
+
+	if status != game.StatusDraft {
+		record.Status = status
+		record.UpdatedAt = now.Add(time.Minute)
+		switch status {
+		case game.StatusRunning, game.StatusPaused, game.StatusFinished:
+			startedAt := now.Add(time.Minute)
+			record.StartedAt = &startedAt
+		}
+		if status == game.StatusFinished {
+			finishedAt := now.Add(2 * time.Minute)
+			record.FinishedAt = &finishedAt
+		}
+	}
+	require.NoError(t, f.games.Save(context.Background(), record))
+	return record
+}
+
+// seedMembership saves an active membership record and reserves the
+// matching race name in the directory. It returns the persisted record.
+func (f *fixtures) seedMembership(
+	t *testing.T,
+	gameID common.GameID,
+	membershipID common.MembershipID,
+	userID, raceName string,
+	now time.Time,
+) membership.Membership {
+	t.Helper()
+
+	record, err := membership.New(membership.NewMembershipInput{
+		MembershipID: membershipID,
+		GameID:       gameID,
+		UserID:       userID,
+		RaceName:     raceName,
+		CanonicalKey: strings.ToLower(strings.ReplaceAll(raceName, " ", "")),
+		Now:          now,
+	})
+	require.NoError(t, err)
+	require.NoError(t, f.memberships.Save(context.Background(), record))
+	require.NoError(t, f.directory.Reserve(context.Background(), gameID.String(), userID, raceName))
+	return record
+}
+
+func (f *fixtures) markMembership(
+	t *testing.T,
+	membershipID common.MembershipID,
+	to membership.Status,
+	at time.Time,
+) {
+	t.Helper()
+
+	require.NoError(t, f.memberships.UpdateStatus(context.Background(), ports.UpdateMembershipStatusInput{
+		MembershipID: membershipID,
+		ExpectedFrom: membership.StatusActive,
+		To:           to,
+		At:           at,
+	}))
+}
+
+func TestNewServiceRejectsMissingDeps(t *testing.T) {
+	t.Parallel()
+
+	_, err := removemember.NewService(removemember.Dependencies{})
+	require.Error(t, err)
+}
+
+func TestRemoveMemberAdminPreStartDropsAndReleasesReservation(t *testing.T) {
+	t.Parallel()
+
+	now := time.Date(2026, 4, 25, 12, 0, 0, 0, time.UTC)
+	f := newFixtures(t)
+	gameRecord := f.seedGame(t, "game-public", game.GameTypePublic, "", game.StatusEnrollmentOpen, now)
+	member := f.seedMembership(t, gameRecord.GameID, "membership-pub", "user-1", "SolarPilot", now)
+
+	at := now.Add(time.Hour)
+	svc := f.newService(t, fixedClock(at))
+
+	result, err := svc.Handle(context.Background(), removemember.Input{
+		Actor:        shared.NewAdminActor(),
+		GameID:       gameRecord.GameID,
+		MembershipID: member.MembershipID,
+	})
+	require.NoError(t, err)
+	assert.Equal(t, membership.StatusRemoved, result.Status)
+	require.NotNil(t, result.RemovedAt)
+	assert.True(t, result.RemovedAt.Equal(at))
+
+	_, getErr := f.memberships.Get(context.Background(), member.MembershipID)
+	require.ErrorIs(t, getErr, membership.ErrNotFound)
+
+	availability, err := f.directory.Check(context.Background(), "SolarPilot", "user-other")
+	require.NoError(t, err)
+	assert.False(t, availability.Taken)
+	assert.Empty(t, availability.HolderUserID)
+}
+
+func TestRemoveMemberAdminPostStartTransitionsAndKeepsReservation(t *testing.T) {
+	t.Parallel()
+
+	now := time.Date(2026, 4, 25, 12, 0, 0, 0, time.UTC)
+	f := newFixtures(t)
+	gameRecord := f.seedGame(t, "game-public", game.GameTypePublic, "", game.StatusRunning, now)
+	member := f.seedMembership(t, gameRecord.GameID, "membership-pub", "user-1", "SolarPilot", now)
+
+	at := now.Add(time.Hour)
+	svc := f.newService(t, fixedClock(at))
+
+	result, err := svc.Handle(context.Background(), removemember.Input{
+		Actor:        shared.NewAdminActor(),
+		GameID:       gameRecord.GameID,
+		MembershipID: member.MembershipID,
+	})
+	require.NoError(t, err)
+	assert.Equal(t, membership.StatusRemoved, result.Status)
+	require.NotNil(t, result.RemovedAt)
+	assert.True(t, result.RemovedAt.Equal(at))
+
+	persisted, err := f.memberships.Get(context.Background(), member.MembershipID)
+	require.NoError(t, err)
+	assert.Equal(t, membership.StatusRemoved, persisted.Status)
+
+	availability, err := f.directory.Check(context.Background(), "SolarPilot", "user-other")
+	require.NoError(t, err)
+	assert.True(t, availability.Taken)
+	assert.Equal(t, "user-1", availability.HolderUserID)
+	assert.Equal(t, ports.KindReservation, availability.Kind)
+}
+
+func TestRemoveMemberPrivateOwnerPreStart(t *testing.T) {
+	t.Parallel()
+
+	now := time.Date(2026, 4, 25, 12, 0, 0, 0, time.UTC)
+	f := newFixtures(t)
+	gameRecord := f.seedGame(t, "game-priv", game.GameTypePrivate, "user-owner", game.StatusEnrollmentOpen, now)
+	member := f.seedMembership(t, gameRecord.GameID, "membership-priv", "user-2", "SolarPilot", now)
+
+	svc := f.newService(t, fixedClock(now.Add(time.Hour)))
+
+	_, err := svc.Handle(context.Background(), removemember.Input{
+		Actor:        shared.NewUserActor("user-owner"),
+		GameID:       gameRecord.GameID,
+		MembershipID: member.MembershipID,
+	})
+	require.NoError(t, err)
+
+	_, getErr := f.memberships.Get(context.Background(), member.MembershipID)
+	require.ErrorIs(t, getErr, membership.ErrNotFound)
+}
+
+func TestRemoveMemberPrivateOwnerPostStart(t *testing.T) {
+	t.Parallel()
+
+	now := time.Date(2026, 4, 25, 12, 0, 0, 0, time.UTC)
+	f := newFixtures(t)
+	gameRecord := f.seedGame(t, "game-priv", game.GameTypePrivate, "user-owner", game.StatusPaused, now)
+	member := f.seedMembership(t, gameRecord.GameID, "membership-priv", "user-2", "SolarPilot", now)
+
+	svc := f.newService(t, fixedClock(now.Add(time.Hour)))
+
+	result, err := svc.Handle(context.Background(), removemember.Input{
+		Actor:        shared.NewUserActor("user-owner"),
+		GameID:       gameRecord.GameID,
+		MembershipID: member.MembershipID,
+	})
+	require.NoError(t, err)
+	assert.Equal(t, membership.StatusRemoved, result.Status)
+
+	persisted, err := f.memberships.Get(context.Background(), member.MembershipID)
+	require.NoError(t, err)
+	assert.Equal(t, membership.StatusRemoved, persisted.Status)
+}
+
+func TestRemoveMemberRejectsPublicGameUserActor(t *testing.T) {
+	t.Parallel()
+
+	now := time.Date(2026, 4, 25, 12, 0, 0, 0, time.UTC)
+	f := newFixtures(t)
+	gameRecord := f.seedGame(t, "game-public", game.GameTypePublic, "", game.StatusEnrollmentOpen, now)
+	member := f.seedMembership(t, gameRecord.GameID, "membership-pub", "user-1", "SolarPilot", now)
+
+	svc := f.newService(t, fixedClock(now.Add(time.Hour)))
+	_, err := svc.Handle(context.Background(), removemember.Input{
+		Actor:        shared.NewUserActor("user-1"),
+		GameID:       gameRecord.GameID,
+		MembershipID: member.MembershipID,
+	})
+	require.ErrorIs(t, err, shared.ErrForbidden)
+}
+
+func TestRemoveMemberRejectsNonOwnerUser(t *testing.T) {
+	t.Parallel()
+
+	now := time.Date(2026, 4, 25, 12, 0, 0, 0, time.UTC)
+	f := newFixtures(t)
+	gameRecord := f.seedGame(t, "game-priv", game.GameTypePrivate, "user-owner", game.StatusEnrollmentOpen, now)
+	member := f.seedMembership(t, gameRecord.GameID, "membership-priv", "user-2", "SolarPilot", now)
+
+	svc := f.newService(t, fixedClock(now.Add(time.Hour)))
+	_, err := svc.Handle(context.Background(), removemember.Input{
+		Actor:        shared.NewUserActor("user-other"),
+		GameID:       gameRecord.GameID,
+		MembershipID: member.MembershipID,
+	})
+	require.ErrorIs(t, err, shared.ErrForbidden)
+}
+
+func TestRemoveMemberRejectsMismatchedGameID(t *testing.T) {
+	t.Parallel()
+
+	now := time.Date(2026, 4, 25, 12, 0, 0, 0, time.UTC)
+	f := newFixtures(t)
+	gameRecord := f.seedGame(t, "game-public", game.GameTypePublic, "", game.StatusEnrollmentOpen, now)
+	member := f.seedMembership(t, gameRecord.GameID, "membership-pub", "user-1", "SolarPilot", now)
+
+	svc := f.newService(t, fixedClock(now.Add(time.Hour)))
+	_, err := svc.Handle(context.Background(), removemember.Input{
+		Actor:        shared.NewAdminActor(),
+		GameID:       common.GameID("game-other"),
+		MembershipID: member.MembershipID,
+	})
+	require.ErrorIs(t, err, membership.ErrNotFound)
+}
+
+func TestRemoveMemberRejectsMissingMembership(t *testing.T) {
+	t.Parallel()
+
+	now := time.Date(2026, 4, 25, 12, 0, 0, 0, time.UTC)
+	f := newFixtures(t)
+	f.seedGame(t, "game-public", game.GameTypePublic, "", game.StatusEnrollmentOpen, now)
+
+	svc := f.newService(t, fixedClock(now.Add(time.Hour)))
+	_, err := svc.Handle(context.Background(), removemember.Input{
+		Actor:        shared.NewAdminActor(),
+		GameID:       "game-public",
+		MembershipID: common.MembershipID("membership-missing"),
+	})
+	require.ErrorIs(t, err, membership.ErrNotFound)
+}
+
+func TestRemoveMemberRejectsAlreadyTerminalMembership(t *testing.T) {
+	t.Parallel()
+
+	cases := []struct {
+		name string
+		to   membership.Status
+	}{
+		{"removed", membership.StatusRemoved},
+		{"blocked", membership.StatusBlocked},
+	}
+
+	for _, tc := range cases {
+		t.Run(tc.name, func(t *testing.T) {
+			t.Parallel()
+
+			now := time.Date(2026, 4, 25, 12, 0, 0, 0, time.UTC)
+			f := newFixtures(t)
+			gameRecord := f.seedGame(t, "game-public", game.GameTypePublic, "", game.StatusRunning, now)
+			member := f.seedMembership(t, gameRecord.GameID, "membership-pub", "user-1", "SolarPilot", now)
+			f.markMembership(t, member.MembershipID, tc.to, now.Add(time.Minute))
+
+			svc := f.newService(t, fixedClock(now.Add(time.Hour)))
+			_, err := svc.Handle(context.Background(), removemember.Input{
+				Actor:        shared.NewAdminActor(),
+				GameID:       gameRecord.GameID,
+				MembershipID: member.MembershipID,
+			})
+			require.ErrorIs(t, err, membership.ErrConflict)
+		})
+	}
+}
+
+func TestRemoveMemberRejectsTerminalGameStatuses(t *testing.T) {
+	t.Parallel()
+
+	statuses := []game.Status{
+		game.StatusDraft,
+		game.StatusFinished,
+		game.StatusCancelled,
+	}
+
+	for _, status := range statuses {
+		t.Run(string(status), func(t *testing.T) {
+			t.Parallel()
+
+			now := time.Date(2026, 4, 25, 12, 0, 0, 0, time.UTC)
+			f := newFixtures(t)
+			gameRecord := f.seedGame(t, "game-public", game.GameTypePublic, "", status, now)
+			member := f.seedMembership(t, gameRecord.GameID, "membership-pub", "user-1", "SolarPilot", now)
+
+			svc := f.newService(t, fixedClock(now.Add(time.Hour)))
+			_, err := svc.Handle(context.Background(), removemember.Input{
+				Actor:        shared.NewAdminActor(),
+				GameID:       gameRecord.GameID,
+				MembershipID: member.MembershipID,
+			})
+			require.ErrorIs(t, err, game.ErrConflict)
+		})
+	}
+}
+
+func TestRemoveMemberInvalidActor(t *testing.T) {
+	t.Parallel()
+
+	f := newFixtures(t)
+	svc := f.newService(t, fixedClock(time.Date(2026, 4, 25, 12, 0, 0, 0, time.UTC)))
+
+	_, err := svc.Handle(context.Background(), removemember.Input{
+		Actor:        shared.Actor{Kind: shared.ActorKindUser},
+		GameID:       "game-x",
+		MembershipID: "membership-x",
+	})
+	require.Error(t, err)
+	require.Contains(t, err.Error(), "actor")
+}
+
+func TestRemoveMemberInvalidIDs(t *testing.T) {
+	t.Parallel()
+
+	f := newFixtures(t)
+	svc := f.newService(t, fixedClock(time.Date(2026, 4, 25, 12, 0, 0, 0, time.UTC)))
+
+	_, err := svc.Handle(context.Background(), removemember.Input{
+		Actor:        shared.NewAdminActor(),
+		GameID:       "bad",
+		MembershipID: "membership-x",
+	})
+	require.Error(t, err)
+
+	_, err = svc.Handle(context.Background(), removemember.Input{
+		Actor:        shared.NewAdminActor(),
+		GameID:       "game-x",
+		MembershipID: "bad",
+	})
+	require.Error(t, err)
+}