test: PlanetProductionDisplayName

internal/controller/planet.go

@@ -125,7 +125,6 @@ func (c *Cache) PlanetProduction(ri int, number int, prod game.ProductionType, s
 	return nil
 }
 
-// TODO: test
 func (c *Cache) PlanetProductionDisplayName(pn uint) string {
 	p := c.MustPlanet(pn)
 	if !p.Owned() {

internal/controller/planet_test.go

@@ -36,54 +36,64 @@ func TestRenamePlanet(t *testing.T) {
 func TestPlanetProduction(t *testing.T) {
 	c, g := newCache()
 
-	first := "Drive_Shields"
+	scienceName := "Drive_Shields"
-	assert.NoError(t, g.CreateScience(Race_0.Name, first, 0.4, 0, 0.6, 0))
+	assert.NoError(t, g.CreateScience(Race_0.Name, scienceName, 0.4, 0, 0.6, 0))
 	assert.Len(t, c.RaceScience(Race_0_idx), 1)
 	scID := c.RaceScience(Race_0_idx)[0].ID
 
+	assert.Equal(t, "-", c.PlanetProductionDisplayName(3))
+
 	pn := int(R0_Planet_0_num)
 	assert.NoError(t, g.PlanetProduction(Race_0.Name, pn, "MAT", ""))
 	assert.Equal(t, game.ProductionMaterial, c.MustPlanet(R0_Planet_0_num).Production.Type)
 	assert.Nil(t, c.MustPlanet(R0_Planet_0_num).Production.SubjectID)
 	assert.Nil(t, c.MustPlanet(R0_Planet_0_num).Production.Progress)
+	assert.Equal(t, "Material", c.PlanetProductionDisplayName(R0_Planet_0_num))
 
 	assert.NoError(t, g.PlanetProduction(Race_0.Name, pn, "CAP", ""))
 	assert.Equal(t, game.ProductionCapital, c.MustPlanet(R0_Planet_0_num).Production.Type)
 	assert.Nil(t, c.MustPlanet(R0_Planet_0_num).Production.SubjectID)
 	assert.Nil(t, c.MustPlanet(R0_Planet_0_num).Production.Progress)
+	assert.Equal(t, "Capital", c.PlanetProductionDisplayName(R0_Planet_0_num))
 
 	assert.NoError(t, g.PlanetProduction(Race_0.Name, pn, "Weapons", "500"))
 	assert.Equal(t, game.ResearchWeapons, c.MustPlanet(R0_Planet_0_num).Production.Type)
 	assert.Nil(t, c.MustPlanet(R0_Planet_0_num).Production.SubjectID)
 	assert.Nil(t, c.MustPlanet(R0_Planet_0_num).Production.Progress)
+	assert.Equal(t, "Weapons", c.PlanetProductionDisplayName(R0_Planet_0_num))
 
 	assert.NoError(t, g.PlanetProduction(Race_0.Name, pn, "cargo", ""))
 	assert.Equal(t, game.ResearchCargo, c.MustPlanet(R0_Planet_0_num).Production.Type)
 	assert.Nil(t, c.MustPlanet(R0_Planet_0_num).Production.SubjectID)
 	assert.Nil(t, c.MustPlanet(R0_Planet_0_num).Production.Progress)
+	assert.Equal(t, "Cargo", c.PlanetProductionDisplayName(R0_Planet_0_num))
 
-	assert.NoError(t, g.PlanetProduction(Race_0.Name, pn, "SHIELDS", first))
+	assert.NoError(t, g.PlanetProduction(Race_0.Name, pn, "SHIELDS", scienceName))
 	assert.Equal(t, game.ResearchShields, c.MustPlanet(R0_Planet_0_num).Production.Type)
 	assert.Nil(t, c.MustPlanet(R0_Planet_0_num).Production.SubjectID)
 	assert.Nil(t, c.MustPlanet(R0_Planet_0_num).Production.Progress)
+	assert.Equal(t, "Shields", c.PlanetProductionDisplayName(R0_Planet_0_num))
 
 	assert.NoError(t, g.PlanetProduction(Race_0.Name, pn, "DrivE", ""))
 	assert.Equal(t, game.ResearchDrive, c.MustPlanet(R0_Planet_0_num).Production.Type)
 	assert.Nil(t, c.MustPlanet(R0_Planet_0_num).Production.SubjectID)
 	assert.Nil(t, c.MustPlanet(R0_Planet_0_num).Production.Progress)
+	assert.Equal(t, "Drive", c.PlanetProductionDisplayName(R0_Planet_0_num))
 
-	assert.NoError(t, g.PlanetProduction(Race_0.Name, pn, "Science", first))
+	assert.NoError(t, g.PlanetProduction(Race_0.Name, pn, "Science", scienceName))
 	assert.Equal(t, game.ResearchScience, c.MustPlanet(R0_Planet_0_num).Production.Type)
 	assert.Nil(t, c.MustPlanet(R0_Planet_0_num).Production.Progress)
 	assert.NotNil(t, c.MustPlanet(R0_Planet_0_num).Production.SubjectID)
 	assert.Equal(t, scID, *c.MustPlanet(R0_Planet_0_num).Production.SubjectID)
+	assert.Equal(t, scienceName, c.PlanetProductionDisplayName(R0_Planet_0_num))
 
 	assert.NoError(t, g.PlanetProduction(Race_0.Name, pn, "SHIP", Race_0_Gunship))
 	assert.Equal(t, game.ProductionShip, c.MustPlanet(R0_Planet_0_num).Production.Type)
 	assert.NotNil(t, c.MustPlanet(R0_Planet_0_num).Production.Progress)
 	assert.NotNil(t, c.MustPlanet(R0_Planet_0_num).Production.SubjectID)
-	stID := c.MustShipClass(Race_0_idx, Race_0_Gunship).ID
+	st := c.MustShipClass(Race_0_idx, Race_0_Gunship)
-	assert.Equal(t, stID, *c.MustPlanet(R0_Planet_0_num).Production.SubjectID)
+	assert.Equal(t, st.ID, *c.MustPlanet(R0_Planet_0_num).Production.SubjectID)
+	assert.Equal(t, st.Name, c.PlanetProductionDisplayName(R0_Planet_0_num))
 
 	pn = int(R0_Planet_2_num)
 	assert.ErrorContains(t,