feat(ui): locale persistence + i18n completeness guards (F3)
Tests · UI / test (push) Waiting to run
Tests · UI / test (pull_request) Successful in 2m11s

An audit found the client already i18n-first: one hard-coded UI string
(the battle-scene aria-label, now keyed) and en/ru already share an
identical 692-key set.

- Persist the locale: i18n.setLocale writes localStorage (galaxy-locale)
  and the store boots from stored > browser detection > default, so a
  language switch survives reloads.
- tests/i18n-completeness.test.ts: en/ru key-set parity, non-empty
  values, and locale persistence.
- Docs: ui/docs/i18n.md; mark F3 done in ui/PLAN-finalize.md.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Ilia Denisov
2026-05-22 08:48:13 +02:00
parent c56050f5dd
commit 1e62837c68
7 changed files with 107 additions and 10 deletions
@@ -23,6 +23,7 @@ combat filter, so a shot never collapses to a single visual node.
<script lang="ts">
import { getContext } from "svelte";
import { i18n } from "$lib/i18n/index.svelte";
import type { BattleReport } from "../../api/battle-fetch";
import {
CORE_CONTEXT_KEY,
@@ -310,7 +311,7 @@ combat filter, so a shot never collapses to a single visual node.
viewBox="0 0 {VIEW_BOX} {VIEW_BOX}"
preserveAspectRatio="xMidYMid meet"
role="img"
aria-label="battle scene"
aria-label={i18n.t("game.battle.scene_label")}
data-testid="battle-scene"
>
<circle
+23 -2
View File
@@ -106,15 +106,36 @@ function isLocale(value: string): value is Locale {
return SUPPORTED_LOCALES.some((entry) => entry.code === value);
}
/** `localStorage` key holding the user's explicit locale choice. */
export const LOCALE_STORAGE_KEY = "galaxy-locale";
function readStoredLocale(): Locale | null {
if (typeof localStorage === "undefined") return null;
const value = localStorage.getItem(LOCALE_STORAGE_KEY);
return value !== null && isLocale(value) ? value : null;
}
/**
* initialLocale resolves the boot locale: an explicit stored choice
* wins, otherwise the browser/system preference, otherwise the default.
*/
function initialLocale(): Locale {
return readStoredLocale() ?? detectInitialLocale();
}
class I18nStore {
locale: Locale = $state(detectInitialLocale());
locale: Locale = $state(initialLocale());
/**
* setLocale changes the active locale. Components reading
* setLocale changes the active locale and persists the choice to
* `localStorage`, so it survives a reload. Components reading
* `i18n.t(...)` re-render automatically through the rune.
*/
setLocale(next: Locale): void {
this.locale = next;
if (typeof localStorage !== "undefined") {
localStorage.setItem(LOCALE_STORAGE_KEY, next);
}
}
/**
+1
View File
@@ -617,6 +617,7 @@ const en = {
"game.battle.not_found": "battle not found",
"game.battle.back_to_report": "back to report",
"game.battle.back_to_map": "back to map",
"game.battle.scene_label": "battle scene",
"game.battle.controls.play": "play",
"game.battle.controls.pause": "pause",
"game.battle.controls.step_forward": "step forward",
+1
View File
@@ -621,6 +621,7 @@ const ru: Record<keyof typeof en, string> = {
"game.battle.not_found": "сражение не найдено",
"game.battle.back_to_report": "к отчёту",
"game.battle.back_to_map": "к карте",
"game.battle.scene_label": "сцена боя",
"game.battle.controls.play": "запустить",
"game.battle.controls.pause": "пауза",
"game.battle.controls.step_forward": "шаг вперёд",